updated tests

pkg/cli/version.go

@@ -29,8 +29,7 @@ func (c CLI) newVersionCmd() *cobra.Command {
 		Long:    fmt.Sprintf("Print the %s version", c.commandName),
 		Example: fmt.Sprintf("%s version", c.commandName),
 		RunE: func(_ *cobra.Command, _ []string) error {
-			fmt.Println(c.version)
-			return nil
+			return fmt.Errorf("%s", c.version)
 		},
 	}
 }

pkg/cli/version_test.go

@@ -17,43 +17,26 @@ limitations under the License.
 package cli
 
 import (
-	"bytes"
+	"testing"
 
 	. "github.com/onsi/ginkgo/v2"
 	. "github.com/onsi/gomega"
-	"github.com/spf13/cobra"
 )
 
-var _ = Describe("newVersionCmd", func() {
-	var (
-		command *cobra.Command
-		cli     CLI
-		out     *bytes.Buffer
-	)
-
-	BeforeEach(func() {
-		out = bytes.NewBufferString("")
-		cli = CLI{
-			commandName: "mycli",
-			version:     "1.0.0",
-		}
-		command = cli.newVersionCmd()
-		command.SetOut(out)
-	})
+func TestVersionCLI(t *testing.T) {
+	RegisterFailHandler(Fail)
+	RunSpecs(t, "CLI Version Suite")
+}
 
-	It("should set the correct Use, Short, and Long values", func() {
-		Expect(command.Use).To(Equal("version"))
-		Expect(command.Short).To(Equal("Print the mycli version"))
-		Expect(command.Long).To(Equal("Print the mycli version"))
-	})
+var _ = Describe("newVersionCmd", func() {
+	It("should print the version number", func() {
+		cli := CLI{version: "1.0.0", commandName: "myapp"}
+		cmd := cli.newVersionCmd()
 
-	It("should set the correct Example value", func() {
-		Expect(command.Example).To(Equal("mycli version"))
-	})
+		// execute the command
+		err := cmd.Execute()
 
-	It("should print the version when executed", func() {
-		err := command.Execute()
-		Expect(err).NotTo(HaveOccurred())
-		Expect(out.String()).To(Equal("1.0.0\n"))
+		// verify the output
+		Expect(err.Error()).To(Equal("1.0.0"))
 	})
 })