Merge pull request #3474 from BronzeDeer/fix-deprecation-completion

🐛 fix(completion): Fix completion in deprecated projects
kubernetes-sigs · Aug 3, 2023 · d08f9d7 · d08f9d7
2 parents e94b7f7 + 0f3db00
commit d08f9d7
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 5 deletions.
diff --git a/pkg/cli/cli.go b/pkg/cli/cli.go
@@ -444,7 +444,7 @@ func (c *CLI) addExtraCommands() error {
 func (c CLI) printDeprecationWarnings() {
 	for _, p := range c.resolvedPlugins {
 		if p != nil && p.(plugin.Deprecated) != nil && len(p.(plugin.Deprecated).DeprecationWarning()) > 0 {
-			fmt.Printf(noticeColor, fmt.Sprintf(deprecationFmt, p.(plugin.Deprecated).DeprecationWarning()))
+			fmt.Fprintf(os.Stderr, noticeColor, fmt.Sprintf(deprecationFmt, p.(plugin.Deprecated).DeprecationWarning()))
 		}
 	}
 }

diff --git a/pkg/cli/cli_test.go b/pkg/cli/cli_test.go
@@ -592,13 +592,13 @@ plugins:
 				)
 				deprecatedPlugin := newMockDeprecatedPlugin("deprecated", "v1", deprecationWarning, projectVersion)
 
-				// Overwrite stdout to read the output and reset it afterwards
+				// Overwrite stderr to read the deprecation output and reset it afterwards
 				r, w, _ := os.Pipe()
-				temp := os.Stdout
+				temp := os.Stderr
 				defer func() {
-					os.Stdout = temp
+					os.Stderr = temp
 				}()
-				os.Stdout = w
+				os.Stderr = w
 
 				c, err = New(
 					WithPlugins(deprecatedPlugin),