Skip to content

Commit

Permalink
🐛 Add validation for the main.go file present in root directory
Browse files Browse the repository at this point in the history
  • Loading branch information
prafull01 committed Oct 16, 2020
1 parent c993a2a commit e1e9897
Show file tree
Hide file tree
Showing 2 changed files with 16 additions and 0 deletions.
8 changes: 8 additions & 0 deletions pkg/plugin/v2/api.go
Original file line number Diff line number Diff line change
Expand Up @@ -38,6 +38,9 @@ import (
"sigs.k8s.io/kubebuilder/plugins/addon"
)

// DefaultMainPath is default file path of main.go
const DefaultMainPath = "main.go"

type createAPIPlugin struct {
config *config.Config

Expand Down Expand Up @@ -131,6 +134,11 @@ func (p *createAPIPlugin) Validate() error {
return err
}

// check if main.go is present in the root directory
if _, err := os.Stat(DefaultMainPath); os.IsNotExist(err) {
return fmt.Errorf("%s file should present in the root directory", DefaultMainPath)
}

reader := bufio.NewReader(os.Stdin)
if !p.resourceFlag.Changed {
fmt.Println("Create Resource [y/n]")
Expand Down
8 changes: 8 additions & 0 deletions pkg/plugin/v3/api.go
Original file line number Diff line number Diff line change
Expand Up @@ -43,6 +43,9 @@ import (
// TODO: remove this when a better solution for using addons is implemented.
const KbDeclarativePatternVersion = "v0.0.0-20200522144838-848d48e5b073"

// DefaultMainPath is default file path of main.go
const DefaultMainPath = "main.go"

type createAPIPlugin struct {
config *config.Config

Expand Down Expand Up @@ -141,6 +144,11 @@ func (p *createAPIPlugin) Validate() error {
return fmt.Errorf("can not have group and domain both empty")
}

// check if main.go is present in the root directory
if _, err := os.Stat(DefaultMainPath); os.IsNotExist(err) {
return fmt.Errorf("%s file should present in the root directory", DefaultMainPath)
}

// TODO: re-evaluate whether y/n input still makes sense. We should probably always
// scaffold the resource and controller.
reader := bufio.NewReader(os.Stdin)
Expand Down

0 comments on commit e1e9897

Please sign in to comment.