Put the manager binary into /, instead of /root/

/root/ encourages use of the root user, and / is more the pattern I've seen for thin containers.
kubernetes-sigs · Nov 29, 2018 · e87227a · e87227a
1 parent c6067b0
commit e87227a
Show file tree

Hide file tree

Showing 4 changed files with 6 additions and 6 deletions.
diff --git a/pkg/scaffold/manager/config.go b/pkg/scaffold/manager/config.go
@@ -84,7 +84,7 @@ spec:
     spec:
       containers:
       - command:
-        - /root/manager
+        - /manager
         image: {{ .Image }}
         imagePullPolicy: Always
         name: manager

diff --git a/pkg/scaffold/manager/dockerfile.go b/pkg/scaffold/manager/dockerfile.go
@@ -50,7 +50,7 @@ RUN CGO_ENABLED=0 GOOS=linux GOARCH=amd64 go build -a -o manager {{ .Repo }}/cmd
 
 # Copy the controller-manager into a thin image
 FROM ubuntu:latest
-WORKDIR /root/
+WORKDIR /
 COPY --from=builder /go/src/{{ .Repo }}/manager .
-ENTRYPOINT ["./manager"]
+ENTRYPOINT ["/manager"]
 `
diff --git a/test/project/Dockerfile b/test/project/Dockerfile
@@ -12,6 +12,6 @@ RUN CGO_ENABLED=0 GOOS=linux GOARCH=amd64 go build -a -o manager sigs.k8s.io/kub
 
 # Copy the controller-manager into a thin image
 FROM ubuntu:latest
-WORKDIR /root/
+WORKDIR /
 COPY --from=builder /go/src/sigs.k8s.io/kubebuilder/test/project/manager .
-ENTRYPOINT ["./manager"]
+ENTRYPOINT ["/manager"]
diff --git a/test/project/config/manager/manager.yaml b/test/project/config/manager/manager.yaml
@@ -42,7 +42,7 @@ spec:
     spec:
       containers:
       - command:
-        - /root/manager
+        - /manager
         image: controller:latest
         imagePullPolicy: Always
         name: manager