We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
It was my understanding that the eventrecorder patches existing events to help reduce the number of event objects that are stored to etcd.
But the leader-election-role, generated by kubebuilder only allows the create verb on events.
The v1 Kubebuilder book also documented that both create and patch verbs are required for events:
AFAICS the client-go leader-election code calls into this event recorder code which may patch or create and event:
The text was updated successfully, but these errors were encountered:
It shows reasonable for me to allow the verb patch by default as well. Let's if someone has some reason for we do not move forward with. Done a PR.
c/c @droot @mengqiy
Sorry, something went wrong.
/assign @camilamacedo86
camilamacedo86
Successfully merging a pull request may close this issue.
It was my understanding that the eventrecorder patches existing events to help reduce the number of event objects that are stored to etcd.
But the leader-election-role, generated by kubebuilder only allows the create verb on events.
The v1 Kubebuilder book also documented that both create and patch verbs are required for events:
AFAICS the client-go leader-election code calls into this event recorder code which may patch or create and event:
The text was updated successfully, but these errors were encountered: