Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

leader-election-role does not allow patch verb on events #1474

Closed
wallrj opened this issue Apr 15, 2020 · 2 comments · Fixed by #1510
Closed

leader-election-role does not allow patch verb on events #1474

wallrj opened this issue Apr 15, 2020 · 2 comments · Fixed by #1510
Assignees

Comments

@wallrj
Copy link

wallrj commented Apr 15, 2020

It was my understanding that the eventrecorder patches existing events to help reduce the number of event objects that are stored to etcd.

But the leader-election-role, generated by kubebuilder only allows the create verb on events.

The v1 Kubebuilder book also documented that both create and patch verbs are required for events:

AFAICS the client-go leader-election code calls into this event recorder code which may patch or create and event:

@camilamacedo86
Copy link
Member

camilamacedo86 commented May 9, 2020

It shows reasonable for me to allow the verb patch by default as well. Let's if someone has some reason for we do not move forward with. Done a PR.

c/c @droot @mengqiy

@camilamacedo86
Copy link
Member

/assign @camilamacedo86

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants