Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add patch verb to events in the leader_election_role #1510

Merged
merged 1 commit into from
May 29, 2020
Merged

add patch verb to events in the leader_election_role #1510

merged 1 commit into from
May 29, 2020

Conversation

camilamacedo86
Copy link
Member

Closes: #1474

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label May 9, 2020
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: camilamacedo86

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels May 9, 2020
@camilamacedo86
Copy link
Member Author

camilamacedo86 commented May 9, 2020 •
edited
Loading

@droot @mengqiy could you please help by checking this one?

djzager
djzager approved these changes May 29, 2020
View reviewed changes
Copy link

@djzager djzager left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 29, 2020
@k8s-ci-robot k8s-ci-robot merged commit c373ad5 into kubernetes-sigs:master May 29, 2020
@camilamacedo86 camilamacedo86 deleted the fix-event-perm branch May 29, 2020 22:38
@camilamacedo86 camilamacedo86 mentioned this pull request Feb 18, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@djzager djzager djzager approved these changes

@Adirio Adirio Awaiting requested review from Adirio

@DirectXMan12 DirectXMan12 Awaiting requested review from DirectXMan12

Assignees

@djzager djzager

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

leader-election-role does not allow patch verb on events
3 participants
@camilamacedo86 @k8s-ci-robot @djzager