Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

upgrade the project to use controller-runtime v0.6.0 #1488

Closed
camilamacedo86 opened this issue May 3, 2020 · 2 comments · Fixed by #1497
Closed

upgrade the project to use controller-runtime v0.6.0 #1488

camilamacedo86 opened this issue May 3, 2020 · 2 comments · Fixed by #1497
Assignees
@camilamacedo86
Labels
kind/feature Categorizes issue or PR as related to a new feature.
Milestone
v3.0.0

Comments

@camilamacedo86
Copy link
Member

Description

go vet ./...
# sigs.k8s.io/kubebuilder-declarative-pattern/pkg/patterns/declarative/pkg/watch
../../../../../pkg/mod/sigs.k8s.io/kubebuilder-declarative-pattern@v0.0.0-20200415210853-85eb326a6add/pkg/patterns/declarative/pkg/watch/dynamic.go:97:29: not enough arguments in call to client.Watch
	have (v1.ListOptions)
	want (context.Context, v1.ListOptions)
make[2]: *** [Makefile:51: vet] Error 2

Shows that we need to upgrade first the https://github.com/kubernetes-sigs/kubebuilder-declarative-pattern/blob/master/go.mod
@camilamacedo86 camilamacedo86 added the kind/feature Categorizes issue or PR as related to a new feature. label May 3, 2020
@DirectXMan12 DirectXMan12 added this to the v3.0.0 milestone May 7, 2020
@camilamacedo86 camilamacedo86 mentioned this issue May 7, 2020
Merged
@camilamacedo86
Copy link
Member Author

camilamacedo86 commented May 7, 2020 •
edited

We will be able to accomplish it when the kubernetes-sigs/kubebuilder-declarative-pattern#93 be merged.

c/c @joelanford @estroz

@camilamacedo86
Copy link
Member Author

/assign @camilamacedo86

@camilamacedo86 camilamacedo86 mentioned this issue May 7, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@camilamacedo86 camilamacedo86

Labels
kind/feature Categorizes issue or PR as related to a new feature.
Projects
None yet
Milestone
v3.0.0
Development

Successfully merging a pull request may close this issue.

upgrade controller-runtime from v0.5.0 to v0.6.0 camilamacedo86/kubebuilder
2 participants
@DirectXMan12 @camilamacedo86