Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: upgrade to use go 1.13 and its deps #93

Merged
merged 1 commit into from
May 7, 2020
Merged

feat: upgrade to use go 1.13 and its deps #93

merged 1 commit into from
May 7, 2020

Conversation

camilamacedo86
Copy link
Member

Description

  • Upgrade to use go 1.13
  • Upgrade to use controller-runtime 0.6 instead of 0.4
  • Upgrade k8s api to v0.18.2
  • Upgrade kustomize to v0.3.2

Motivation

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. labels May 7, 2020
@k8s-ci-robot k8s-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label May 7, 2020
@camilamacedo86
Copy link
Member Author

/assign @johnsonj

@camilamacedo86
Copy link
Member Author

/assign @droot

@camilamacedo86 camilamacedo86 mentioned this pull request May 7, 2020
Closed
@johnsonj
Copy link
Contributor

johnsonj commented May 7, 2020

/lgtm
/approve

thank you @camilamacedo86 !

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 7, 2020
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: camilamacedo86, johnsonj

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 7, 2020
@k8s-ci-robot k8s-ci-robot merged commit d901af4 into kubernetes-sigs:master May 7, 2020
@camilamacedo86 camilamacedo86 deleted the upgrade branch May 7, 2020 22:00
@estroz estroz mentioned this pull request May 8, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@atoato88 atoato88 Awaiting requested review from atoato88

@droot droot Awaiting requested review from droot

Assignees

@droot droot

@johnsonj johnsonj

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@camilamacedo86 @johnsonj @k8s-ci-robot @droot