Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add make check-testdata to the prow CI #1503

Closed
camilamacedo86 opened this issue May 8, 2020 · 1 comment · Fixed by #1527
Closed

Add make check-testdata to the prow CI #1503

camilamacedo86 opened this issue May 8, 2020 · 1 comment · Fixed by #1527
Labels
kind/feature Categorizes issue or PR as related to a new feature.

Comments

@camilamacedo86
Copy link
Member

camilamacedo86 commented May 8, 2020

This task is for we add in the prow the test which checks if the testdata is updated. The reason for that is avoid broke the CI for the master branch. Following a scenario as an example.

The mod kubebuilder-declarative-pattern is added when the testdata add-on project is gen, if it changes after the PR be pushed and the CI finished then, the boot will merge the PR in the master because it will just re-run the prow tests. However, the make check-testdata for the master branch will be executed after the merge and will fail.

Notes

  • Check the contribution.md to have further information and be able to add this test in the prow.
@camilamacedo86 camilamacedo86 added the kind/feature Categorizes issue or PR as related to a new feature. label May 8, 2020
@camilamacedo86
Copy link
Member Author

c/c @mengqiy @alexeldeib

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/feature Categorizes issue or PR as related to a new feature.
Projects
None yet
1 participant