Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: fixed version of sigs.k8s.io/kubebuilder-declarative-pattern which should be used #1527

Merged
merged 1 commit into from
Jun 1, 2020
Merged

fix: fixed version of sigs.k8s.io/kubebuilder-declarative-pattern which should be used #1527

merged 1 commit into from
Jun 1, 2020

Conversation

camilamacedo86
Copy link
Member

@camilamacedo86 camilamacedo86 commented May 26, 2020 •
edited
Loading

Closes: #1525
Closes: #1503 (no longer required after it as well)

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels May 26, 2020
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: camilamacedo86

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 26, 2020
@camilamacedo86
Copy link
Member Author

/assign @droot @mengqiy

@camilamacedo86 camilamacedo86 mentioned this pull request May 26, 2020
Merged
@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels May 27, 2020
@camilamacedo86 camilamacedo86 mentioned this pull request May 27, 2020
Merged
@mengqiy
Copy link
Member

mengqiy commented May 28, 2020

I don't quite understand why we need this?

@camilamacedo86
Copy link
Member Author

The addon requires the kubernetes-sigs/kubebuilder-declarative-pattern, however, its version is not defined/specified for the projects built with KB. In this way, KB will start to scaffold any new change introduced in the project which can be indeed a breaking change. Another common scenario, which is low important since do not affect the users, is that it makes the CI break. See the master now here.

However, it has not changed so much and because of this, I think that it did not bring attention.
So, fixed the version shows reasonable besides I do not like the fixed replace. Is it make sense?

DirectXMan12
DirectXMan12 requested changes May 29, 2020
View reviewed changes
Copy link
Contributor

@DirectXMan12 DirectXMan12 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It doesn't quite seem like the right decision to add a kb-declarative-pattern override to all scaffolded projects, regardless of whether or not they use it. Can you explain a bit more?

@camilamacedo86
Copy link
Member Author

camilamacedo86 commented May 29, 2020 •
edited
Loading

Hi @DirectXMan12,

Yep. I agree. I will come up with a solution that will ensure a fixed version just for when we use the addon. Until there, for we fix the CI I did the PR #1532

@camilamacedo86 camilamacedo86 changed the title fix: fixed version of sigs.k8s.io/kubebuilder-declarative-pattern which should be used WIP : fix: fixed version of sigs.k8s.io/kubebuilder-declarative-pattern which should be used May 29, 2020
@k8s-ci-robot k8s-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label May 29, 2020
@camilamacedo86 camilamacedo86 mentioned this pull request May 29, 2020
Merged
@camilamacedo86 camilamacedo86 changed the title WIP : fix: fixed version of sigs.k8s.io/kubebuilder-declarative-pattern which should be used fix: fixed version of sigs.k8s.io/kubebuilder-declarative-pattern which should be used May 29, 2020
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label May 29, 2020
@camilamacedo86
Copy link
Member Author

Hi @DirectXMan12,
Now it is solved in the correct way. 👍

@camilamacedo86
Copy link
Member Author

/hold
Until @DirectXMan12 be able to check.

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label May 29, 2020
@camilamacedo86
Copy link
Member Author

/kind bug

@k8s-ci-robot k8s-ci-robot added the kind/bug Categorizes issue or PR as related to a bug. label May 30, 2020
@DirectXMan12
Copy link
Contributor

I think this is fine for now. We probably want to follow up with the addon folks to see what's going on there, and eventually turn this into a proper plugin with plugins stage two

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 1, 2020
@camilamacedo86 camilamacedo86 mentioned this pull request Jun 1, 2020
Closed
@camilamacedo86
Copy link
Member Author

/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jun 1, 2020
@camilamacedo86
Copy link
Member Author

camilamacedo86 commented Jun 1, 2020 •
edited
Loading

Tracked an issue to do the following up #1543

@k8s-ci-robot k8s-ci-robot merged commit 4f9483f into kubernetes-sigs:master Jun 1, 2020
@camilamacedo86 camilamacedo86 deleted the fix-module-ver branch June 2, 2020 00:10
@estroz estroz mentioned this pull request Jun 2, 2020
Merged
@camilamacedo86 camilamacedo86 mentioned this pull request Feb 18, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@droot droot Awaiting requested review from droot

@mengqiy mengqiy Awaiting requested review from mengqiy

@DirectXMan12 DirectXMan12 Awaiting requested review from DirectXMan12

Assignees

@DirectXMan12 DirectXMan12

@droot droot

@mengqiy mengqiy

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

controller-gen is unable to work with addons projects. Add make check-testdata to the prow CI
5 participants
@camilamacedo86 @k8s-ci-robot @mengqiy @DirectXMan12 @droot