Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: controller alias for multigroups (v3) #1498

Merged
merged 1 commit into from
Jun 19, 2020
Merged

fix: controller alias for multigroups (v3) #1498

merged 1 commit into from
Jun 19, 2020

Conversation

camilamacedo86
Copy link
Member

@camilamacedo86 camilamacedo86 commented May 8, 2020 •
edited
Loading

Description

  • Fix controller alias

Motivation

Closes: #1382

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label May 8, 2020
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: camilamacedo86

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 8, 2020
@camilamacedo86

This comment has been minimized.

Sign in to view
@camilamacedo86 camilamacedo86 changed the title fix: typo controller import alias wip: fix: typo controller import alias May 8, 2020
@k8s-ci-robot k8s-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label May 8, 2020
@camilamacedo86 camilamacedo86 changed the title wip: fix: typo controller import alias fix: typo controller import alias May 8, 2020
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label May 8, 2020
@camilamacedo86

This comment has been minimized.

Sign in to view
Adirio
Adirio suggested changes May 13, 2020
View reviewed changes
Copy link
Contributor

@Adirio Adirio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This can only be applied to v3 projects and onwards

@camilamacedo86 camilamacedo86 changed the title fix: typo controller import alias WIP: fix: typo controller import alias May 13, 2020
@k8s-ci-robot k8s-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label May 13, 2020
@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels May 14, 2020
@camilamacedo86 camilamacedo86 changed the title WIP: fix: typo controller import alias fix: typo controller import alias for V3 May 14, 2020
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label May 14, 2020
@camilamacedo86

This comment has been minimized.

Sign in to view
@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label May 14, 2020
@estroz
Copy link
Contributor

estroz commented May 14, 2020 •
edited
Loading

We now have a project version and a plugin layout version. The layout determines the plugin (read: scaffold) used to generate a project, while the project version determines the format of PROJECT. This change should probably be a plugin version bump, i.e. go.kubebuilder.io/v2.1.0 and not be specific to a project version.

@camilamacedo86 camilamacedo86 force-pushed the controllers-scaff branch 4 times, most recently from 5d678bd to 50c1c6d Compare May 14, 2020 22:58
@k8s-ci-robot k8s-ci-robot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Jun 5, 2020
@estroz estroz mentioned this pull request Jun 10, 2020
Merged
@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jun 17, 2020
@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Jun 19, 2020
@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jun 19, 2020
@camilamacedo86 camilamacedo86 changed the title feat: add plugin to fix controller typo alias and improve its logs (only V3) fix; controller typo alias and improve its logs for multigroup support (only V3) Jun 19, 2020
@camilamacedo86
Copy link
Member Author

/hold cancel
We have here now only the change and then, it can be merged.

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jun 19, 2020
estroz
estroz reviewed Jun 19, 2020
View reviewed changes
pkg/plugin/v3/scaffolds/internal/templates/main.go Outdated
Client: mgr.GetClient(),
Log: ctrl.Log.WithName("controllers").WithName("%s"),
Log: ctrl.Log.WithName("controllers").WithName("%s").WithName("%s"),
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Log: ctrl.Log.WithName("controllers").WithName("%s").WithName("%s"),
Log: ctrl.Log.WithName("controllers").WithName("%s"),

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Disregard.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Split as requested.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Eh this can probably go in the same PR since it's related. I didn't see the TODO above this change.

Copy link
Member Author

@camilamacedo86 camilamacedo86 Jun 19, 2020 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done already in another pr. You are right, the correct way is to have 1 pr for each change/motivation.

@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jun 19, 2020
@camilamacedo86 camilamacedo86 changed the title fix; controller typo alias and improve its logs for multigroup support (only V3) fix: controller alias for multigroups (v3) Jun 19, 2020
@camilamacedo86 camilamacedo86 mentioned this pull request Jun 19, 2020
Merged
@camilamacedo86
Copy link
Member Author

/test pull-kubebuilder-e2e-k8s-1-14-1

@estroz
Copy link
Contributor

estroz commented Jun 19, 2020

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 19, 2020
@k8s-ci-robot k8s-ci-robot merged commit fe6002b into kubernetes-sigs:master Jun 19, 2020
@camilamacedo86 camilamacedo86 deleted the controllers-scaff branch June 19, 2020 22:18
@camilamacedo86 camilamacedo86 mentioned this pull request Feb 18, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DirectXMan12 DirectXMan12 Awaiting requested review from DirectXMan12

@joelanford joelanford Awaiting requested review from joelanford

@Adirio Adirio Awaiting requested review from Adirio

@estroz estroz Awaiting requested review from estroz

Assignees

@estroz estroz

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[V3] Multi-group controller import alias
4 participants
@camilamacedo86 @k8s-ci-robot @estroz @Adirio