Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

would be nice the edit multi-group:true fixes the layout of the project and move the pre-existing api's #1640

Closed
camilamacedo86 opened this issue Aug 17, 2020 · 8 comments
Assignees
Labels
kind/feature Categorizes issue or PR as related to a new feature.

Comments

@camilamacedo86
Copy link
Member

Currently, when we use the command edit --multigroup=true it will update the Dockerfile and the PROJECT file and then the new API's will be scaffolded in a diff layout where the group is use in the path.

However, if the project has API's scaffolded already users requires to move them and create the path with the group name manually. I think would be nice if the command could do all process instead of requires manually changes.

@camilamacedo86 camilamacedo86 added the kind/feature Categorizes issue or PR as related to a new feature. label Aug 17, 2020
@camilamacedo86
Copy link
Member Author

c/c @estroz

@prafull01
Copy link
Contributor

@camilamacedo86 If no one is working on it, I would be happy to pick it up.

@camilamacedo86
Copy link
Member Author

Hi @prafull01,

Your help is more than welcome 👍 it is great . Please, feel free to help and work on in any issue that pleases you.

@camilamacedo86
Copy link
Member Author

camilamacedo86 commented Sep 22, 2020

Hi @prafull01,

maybe would be easier if we could do first this one: #1689. However, please feel free to solve it as you think that would be the best way.

@prafull01
Copy link
Contributor

/assign

@camilamacedo86
Copy link
Member Author

Another ticked that is related and could make easier we keep the current behaviour for v2 and new behaviour for v3 only would be the issue #1639 to make the edit to be a plugin as well. See that we have a plugin to create the api, other to init the project and another to scaffold the webhooks.

So, feel free to analyse and see the best approach for we address that. However, just to share and try to help the following sequence might simplify its implementations:

@prafull01
Copy link
Contributor

Sounds perfect.

@camilamacedo86
Copy link
Member Author

It was deferred since we consider in the bug triage meeting hard to keep the RFE maintained because users might customize their files which would be hard to edit after the scaffold.

Also, the multi-group feature is used in more advanced and specific scenarios so shows fine in this case users do the required changes manually when required.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/feature Categorizes issue or PR as related to a new feature.
Projects
None yet
Development

No branches or pull requests

2 participants