🐛 kubebuilder edit ignore the errors if the project layout is already on same type

[prafull01]

Description of the change

Add validation of kb edit command if the scaffolding is already on same side either multigroup: true or multigroup: false. kb edit command fails when it tries to change the Dockerfile that it doesn't find the apis or api directory respectively.

Motivation of the change
Fixes: #1747

[camilamacedo86]

I do not think that we should do that because:

• The plugin/command kb edit can have more than one arg besides it has only the multigroup
• We can enable/disable the support via kb edit --multigroup=[true or false]

However, we could check if the project has multi-group resources scaffolded already before allow remove the support. WDYT?

[prafull01]

I do not think that we should do that because:

* The plugin/command kb edit can have more than one arg besides it has only the multigroup

* We can enable/disable the support via kb edit --multigroup=[true or false]

However, we could check if the project has multi-group resources scaffolded already before allow remove the support. WDYT?

The current implementation also fails if we try to edit a project which is already on the same type. Current, failure happens in the PostScaffolding of the kb edit command.

prafull@EMPID18004:~/go/src/github.com/prafull01/kubebuilder/proj$ ../bin/kubebuilder edit --multigroup=true
prafull@EMPID18004:~/go/src/github.com/prafull01/kubebuilder/proj$ ../bin/kubebuilder edit --multigroup=true
Error: failed to edit project with version "3-alpha": can't find "COPY api/ api/"
Usage:
  kubebuilder edit [flags]

Examples:
# Enable the multigroup layout
        kubebuilder edit --multigroup

        # Disable the multigroup layout
        kubebuilder edit --multigroup=false
	

Flags:
  -h, --help         help for edit
      --multigroup   enable or disable multigroup layout

2020/10/30 00:13:52 failed to edit project with version "3-alpha": can't find "COPY api/ api/"

This change will give more clear message to the user that he is already on the same type of the project layout.
Also, this change will become more important when we add #1640 . When we try to modify the layout of the project, we don't need to do anything is the project is already on the same layout.

[camilamacedo86]

@prafull01, I catcher the scenario 👍
Great catcher, btw.

However, it is a really bugfix in POV. So, wdyt about update the title with :bug; and to do the same for v2?

[prafull01]

@prafull01, I catcher the scenario +1
Great catcher, btw.

However, it is a really bugfix in POV. So, wdyt about update the title with :bug; and to do the same for v2?

Done

[camilamacedo86]

great 👍
/approve

[prafull01]

@camilamacedo86 Needs /ok-to-test command to run the tests. Thanks :)

[camilamacedo86]

/ok-to-test

[camilamacedo86]

/approve cancel

Hi @prafull01,

After tests and think about that more, I believe that it is not the best approach for we avoid this issue.
See that after this pr if we run kubebuilder edit it will return the issue added here instead of the helper. So, WDYT about we add a check in the Dockerfile update here to ignore the issue if the projectfile==multigroup value and the error faced is can't find "COPY?

[camilamacedo86]

/approve

Great work 👍

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: camilamacedo86, prafull01

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [camilamacedo86]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[camilamacedo86]

Tested locally and the bug fixed work.
Since it is a very tiny fix I think that is fine we get it merged.

/lgtm