Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Run go vet against generated files #171

Closed
perotinus opened this issue May 16, 2018 · 1 comment
Closed

Run go vet against generated files #171

perotinus opened this issue May 16, 2018 · 1 comment
Labels
good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. revisit-later
Milestone
?

Comments

@perotinus
Copy link
Contributor

It would be helpful if kubebuilder would run a basic go vet against the generated code. Currently, projects have to do this themselves.

This might be covered by #147 which added support for formatting.
@perotinus perotinus mentioned this issue May 16, 2018
Merged
@pwittrock pwittrock added enhancement good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. labels May 17, 2018
@pwittrock pwittrock reopened this May 30, 2018
@pwittrock pwittrock added this to the ? milestone May 30, 2018
@pwittrock
Copy link
Contributor

Closing to keep issue count from inflating. Will track through milestone and project.

luffyao pushed a commit to luffyao/kubebuilder that referenced this issue Aug 12, 2020
@mergify
Merge pull request kubernetes-sigs#171 from Luffy110/zh
e4abc48 
翻译4.4 webhook-overview 章节
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. revisit-later
Projects
None yet
Milestone
?
Development

No branches or pull requests
2 participants
@perotinus @pwittrock