-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Controllers in a multigroup project belong to the 'controllers' package #1717
Comments
Hi @miguelsorianod, thank you for raise it. Could you please let us know if you will be working on to solve this scenario? if yes, could you please assign the issue to your self? Also, since it does not cause issues wdyt about we classify it as an RFE? |
Hi @camilamacedo86, I'll work on this yes. |
/assign |
Hi @camilamacedo86, I've submitted a PR #1729 with the changes. Let me know what you think about them. Thank you. |
I would classify that as RFE instead of a bug. Otherwise, I am totally all in for that 👍 |
The PR with this RFE has been merged to master. We can close this one. @camilamacedo86 |
@prafull01: You can't close an active issue/PR unless you authored it or you are a collaborator. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Hi,
I'm using operator-sdk v1.0.1, which, if I've understood correctly makes use of Kubebuilder for some of its commands.
I'm working on migrating an operator-sdk based project to operator-sdk 1.x version.
I've created the new project with the
multigroup: true
setting in thePROJECT
file. Once that is done I generate the controller withoperator-sdk create api ...
, which after looking at the code I think is a command that belongs to kubebuilder, and I can see the directory structure is like this:However, in the Go file of the controller I can see it has the following package definition:
Notice how the package is
controllers
instead ofapps
. Is that expected/intentional? Might that be a bug? It seems odd.I would have expected the package to be named
apps
in that directory.With the current implementation I understand all controllers between different groups are sharing the same package name right now.
If you think this should be changed I'd be interested in contributing a change for this.
Software versions being used:
operator-sdk v1.0.1
, which I think uses the Go v2 plugin currentlyThank you.
/kind bug
The text was updated successfully, but these errors were encountered: