Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change module to v3 (can be done only when we will cut the 3.0.0-alpha release) #1798

Closed
4 tasks
Adirio opened this issue Nov 7, 2020 · 4 comments
Closed
4 tasks

Change module to v3 (can be done only when we will cut the 3.0.0-alpha release) #1798

Adirio opened this issue Nov 7, 2020 · 4 comments
Assignees
@camilamacedo86
Labels
kind/feature Categorizes issue or PR as related to a new feature.
Milestone
v3.0.0

Comments

@Adirio
Copy link
Contributor

Adirio commented Nov 7, 2020 •
edited

  • Update module name in go.mod to sigs.k8s.io/kubebuilder/v3
  • Update the build command in generate_testdata.sh to go build -o ./bin/kubebuilder sigs.k8s.io/kubebuilder/v3/cmd
  • Update imports to v3: sigs.k8s.io/kubebuilder/v2 -> sigs.k8s.io/kubebuilder/v3
  • Update -ldflags paths to v3 in common.sh and build/.goreleaser.yml

Equivalent v2 PR: #1792
@Adirio Adirio added the kind/feature Categorizes issue or PR as related to a new feature. label Nov 7, 2020
@Adirio
Copy link
Contributor Author

Adirio commented Nov 7, 2020

@camilamacedo86 could you add this to the v3.0.0 milestone?

@Adirio Adirio mentioned this issue Nov 7, 2020
Merged
@camilamacedo86 camilamacedo86 added this to the v3.0.0 milestone Nov 7, 2020
@camilamacedo86 camilamacedo86 mentioned this issue Nov 16, 2020
Closed
@camilamacedo86 camilamacedo86 self-assigned this Nov 17, 2020
@camilamacedo86
Copy link
Member

Besides we are unable to push a patch release from master the import of the pkg will still v2.3.1-abc-123. See; https://github.com/operator-framework/operator-sdk/blob/master/go.mod#L37

@camilamacedo86 camilamacedo86 removed their assignment Nov 18, 2020
@camilamacedo86 camilamacedo86 changed the title Change module to v3 Change module to v3 (can be done only when we will cut the 3.0.0-alpha release) Nov 18, 2020
@camilamacedo86
Copy link
Member

Hi @Adirio and @estroz,

We should get it done before release the alpha one. However, I think we can move forward here now as well.

@camilamacedo86 camilamacedo86 mentioned this issue Jan 18, 2021
Merged
@camilamacedo86 camilamacedo86 self-assigned this Jan 18, 2021
@camilamacedo86
Copy link
Member

Done.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@camilamacedo86 camilamacedo86

Labels
kind/feature Categorizes issue or PR as related to a new feature.
Projects
None yet
Milestone
v3.0.0
Development

Successfully merging a pull request may close this issue.

🌱 update module v2/ to v3/ camilamacedo86/kubebuilder
2 participants
@Adirio @camilamacedo86