Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

⚠️ upgrade kubebuilder module from v2 to v3 #1958

Merged
merged 1 commit into from
Jan 19, 2021
Merged

⚠️ upgrade kubebuilder module from v2 to v3 #1958

merged 1 commit into from
Jan 19, 2021

Conversation

camilamacedo86
Copy link
Member

Description
upgrade kubebuilder module from v2 to v3

Motivation
#1798

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Jan 18, 2021
@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 18, 2021
estroz
estroz approved these changes Jan 18, 2021
View reviewed changes
Copy link
Contributor

@estroz estroz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One question. Also @Adirio this doesn't affect the v2.3.2 release correct?

/approve

generate_testdata.sh Outdated Show resolved Hide resolved
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: camilamacedo86, estroz

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [camilamacedo86,estroz]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@camilamacedo86
Copy link
Member Author

camilamacedo86 commented Jan 18, 2021 •
edited
Loading

Hi @estroz, @Adirio

One question. Also @Adirio this doesn't affect the v2.3.2 release correct?

How it would affect the v2.3.2 release? It has its branch https://github.com/kubernetes-sigs/kubebuilder/tree/release-2 if we need to do a patch release. Please, let me know if I am misunderstood something here.

@Adirio
Copy link
Contributor

Adirio commented Jan 18, 2021

Also @Adirio this doesn't affect the v2.3.2 release correct?

It shouldn't, its on a separate branch. We added v2 and it didnt affect v2.3.1 because it was already on a separate branch.

@Adirio
Copy link
Contributor

Adirio commented Jan 18, 2021

My issue with this PR is that it will break any pending PR and right now there are several. It needs to be done but I think we need to time it a bit better.

@camilamacedo86
Copy link
Member Author

camilamacedo86 commented Jan 18, 2021 •
edited
Loading

Hi @Adirio,

My issue with this PR is that it will break any pending PR and right now there are several. It needs to be done but I think we need to time it a bit better.

I know that to do teh rebases and solve the conflicts are not something funny. However, we will always have open prs that will be affected by that. See that it should be done already, I mean before the first nightly alpha release for v3.

Also, what pr do you have that you would like to merge before?

@Adirio
Copy link
Contributor

Adirio commented Jan 18, 2021 •
edited
Loading

The changes done here are correct except for the mentioned one above. Haven't checked if there is any v2 remaining though.

@Adirio
Copy link
Contributor

Adirio commented Jan 19, 2021

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 19, 2021
@k8s-ci-robot k8s-ci-robot merged commit e3e3658 into kubernetes-sigs:master Jan 19, 2021
@camilamacedo86 camilamacedo86 deleted the v3-dep branch January 19, 2021 12:17
@camilamacedo86 camilamacedo86 mentioned this pull request Feb 18, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Adirio Adirio Adirio left review comments

@estroz estroz estroz approved these changes

@mengqiy mengqiy Awaiting requested review from mengqiy

@pwittrock pwittrock Awaiting requested review from pwittrock

Assignees

@Adirio Adirio

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@camilamacedo86 @k8s-ci-robot @Adirio @estroz