Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Wrong path for probes #1904

Closed
zoetrope opened this issue Dec 14, 2020 · 2 comments
Closed

Wrong path for probes #1904

zoetrope opened this issue Dec 14, 2020 · 2 comments
Labels
kind/bug Categorizes issue or PR as related to a bug.

Comments

@zoetrope
Copy link
Contributor

When I generated the codes with kubebuilder v3-alpha.0, I got the following manifest:

        livenessProbe:
          httpGet:
            path: /readyz
            port: 8081
          initialDelaySeconds: 15
          periodSeconds: 20
        readinessProbe:
          httpGet:
            path: /healthz
            port: 8081
          initialDelaySeconds: 5
          periodSeconds: 10

Is this correct?
I believe readinessProbe should use readyz.

/kind bug
@k8s-ci-robot k8s-ci-robot added the kind/bug Categorizes issue or PR as related to a bug. label Dec 14, 2020
@zoetrope zoetrope mentioned this issue Dec 14, 2020
Merged
@estroz
Copy link
Contributor

estroz commented Dec 14, 2020

Closed by #1905

/close

@k8s-ci-robot
Copy link
Contributor

@estroz: Closing this issue.

In response to this:

Closed by #1905

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
kind/bug Categorizes issue or PR as related to a bug.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@zoetrope @estroz @k8s-ci-robot