-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Error invalid value for project version
appears without let us know what values are available
#1914
Comments
Project versions do not support the
|
Yeah this is a validation error. I don't see what better error kubebuilder could produce if the project version doesn't have the correct format. /remove-kind bug |
Closing this as it should be solved just by removing the invalid |
/close |
@Adirio: Closing this issue. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
The point here is that We should output the help with that. For all CLI errors, we should output the help and not ONLY the error itself. Is not the common behaviour for the CLI? PS.: I believe that it was showing the help before the latest changes.
|
Outputting command help is fine with me, or a list of available project versions. |
It is a bug because what is expected for any CLI/tool command is:
|
I 100% agree that printing the regex is not a very good UX, I will work on showing the available project versions instead of the regex. IMO printing the whole command help should be reserved for those cases where the use intention is not clear. In this case the intention is clearly to provide a valid project version but he failed, so a clear error message that includes available project versions should be clear an concise while printing the whole command help may add noise. |
/assign |
With #1937, the output to
Should this be enough? Any suggested changes? |
Unable to use the help to check the plugins versions available for an project version:
When I would expect to see:
PS.: It shows a bug introduced in the latest changes.
c/c @estroz @Adirio
The text was updated successfully, but these errors were encountered: