Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Resource validations #1973

Closed
Adirio opened this issue Jan 26, 2021 · 0 comments · Fixed by #1974
Closed

Resource validations #1973

Adirio opened this issue Jan 26, 2021 · 0 comments · Fixed by #1974
Labels
kind/feature Categorizes issue or PR as related to a new feature. triage/accepted Indicates an issue or PR is ready to be actively worked on.

Comments

@Adirio
Copy link
Contributor

Adirio commented Jan 26, 2021

Description

Currently, the Options objects, which are used to store all the data input from flags, are the ones that are being validated so that they can create a new Reosurce. While some of these validations do belong to the Options objects, there are several of these validations that should belong to the Resource object itself.

Proposal

Split the validations in those belonging to the Resource objects and those that should still be part of the Options objects so that Resources can be built from different sources and still be validated.

/kind feature
@Adirio Adirio added the kind/feature Categorizes issue or PR as related to a new feature. label Jan 26, 2021
@Adirio Adirio mentioned this issue Jan 26, 2021
Merged
@camilamacedo86 camilamacedo86 added the triage/accepted Indicates an issue or PR is ready to be actively worked on. label Jan 26, 2021
@camilamacedo86 camilamacedo86 mentioned this issue Feb 26, 2021
Merged
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
kind/feature Categorizes issue or PR as related to a new feature. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

⚠ Resource validation Adirio/kubebuilder
2 participants
@Adirio @camilamacedo86