(helm/v1) run create api plugin only after init plugin finishes execution

[estroz]

Description of the change:

• internal/plugins/helm/v1/chartutil: have CreateChart() return a resource.Resource instead of golang.Options
• internal/plugins/helm/v1: refactor to run createAPISubcommand after initSubcommand finishes execution

Motivation for the change:
This PR fixes samples kustomization.yaml generation when running operator-sdk init --plugins=helm --helm-chart=<chart>, an error caused by out-of-order operations in plugin code.

Closes #4575

/kind bug

Checklist

If the pull request includes user-facing changes, extra documentation is required:

• Add a new changelog fragment in changelog/fragments (see changelog/fragments/00-template.yaml)
• Add or update relevant sections of the docs website in website/content/en/docs

[estroz]

/cc @jmrodri @joelanford

[estroz]

This fix should be applied to ansible plugin code as well.

[joelanford]

Is there a reason we're using golang.Options and not just resource.Resource directly? It seems a little strange that the helm plugin has a dependency on the Go plugin.

[estroz]

golang.Options.NewResource() configures a resource more thoroughly. That code could perhaps be copied to the operator-sdk internally or made more generic upstream (this was the case previously but was refactored for compartmentalization reasons I think).

[camilamacedo86]

HI @joelanford,

I agree 100%. It is not good but the good news is that was discussed already. We have todos in the SDK code to fix that. Changes were made in KB side and we toke to long to align it here and then, we agreed to move forward with todos and solve it in a follow-up since kb should provide the funcs to create a new resource and validate it according to its rules outside of the golang.options.

See: kubernetes-sigs/kubebuilder#1973 and kubernetes-sigs/kubebuilder#1974. Also, see kubernetes-sigs/kubebuilder#1986 and kubernetes-sigs/kubebuilder#1986 (comment).

[Adirio]

Just as an addition to Camila and Eric's comments, this is made more generic with the plugin phase 1.5 implementation. As plugins are chainable, the resource is created by the CLI and injected into the plugin which no longer has the responsability to create the resource itself. #4581 shows how SDK would be aligned to kubebuilder after 1.5 implementation, and there we no longer have this dependency.

[estroz]

I'm considering blocking this on #4581 since it elegantly solves this problem with new kubebuilder plugin interfaces. Not sure if #4581 will be merged in the near future.

[estroz]

/retest

[camilamacedo86]

HI @estroz, @Adirio,

Would it be a big problem we merge with this and then with the @Adirio's PR #4581? Would very hard or not to solve the conflicts?

Also, are we covering now via tests the scenario which motivates this change in the first place? I think would be important we ensure that via tests as well.

[Adirio]

#4581 also fixes this issue. Eric even mentioned that he may drop this in favor of the other. I told him not to do it because this fix can be done right away while #4581 timeline was more uncertain (it is a bit less uncertain now) and this still offers a fix right now and I don't need to edit anything when rebasing.

[camilamacedo86]

@estroz fantastic work 🥇
I tested locally and all workout.

$ operator-sdk init --plugins helm --helm-chart ../hack/generate/samples/internal/helm/ 

$ make bundle
operator-sdk generate kustomize manifests -q

Display name for the operator (required): 
> g

Description for the operator (required): 
> g

Provider's name for the operator (required): 
> g

Any relevant URL for the provider name (optional): 
> g

Comma-separated list of keywords for your operator (required): 
> g

Comma-separated list of maintainers and their emails (e.g. 'name1:email1, name2:email2') (required): 
> g
cd config/manager && /Users/camilamacedo/go/src/github.com/operator-framework/operator-sdk/testhelm/bin/kustomize edit set image controller=controller:latest
g/Users/camilamacedo/go/src/github.com/operator-framework/operator-sdk/testhelm/bin/kustomize build config/manifests | operator-sdk generate bundle -q --overwrite --version 0.0.1  
operator-sdk bundle validate ./bundle
INFO[0000] Found annotations file                        bundle-dir=bundle container-tool=docker
INFO[0000] Could not find optional dependencies file     bundle-dir=bundle container-tool=docker
INFO[0000] All validation tests have completed successfully

/approved
/lgtm

[estroz]

Follow-up: #4599