Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨ Constructor for Resource #1986

Closed
wants to merge 1 commit into from

Conversation

Adirio
Copy link
Contributor

@Adirio Adirio commented Feb 2, 2021

Provide a constructor for Resource in order to better split the model from the command flag options for each plugin so that third-party can consume this API instead of creating an Options object.

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Feb 2, 2021
@Adirio
Copy link
Contributor Author

Adirio commented Feb 2, 2021

/hold

Waiting until #1974 is merged so that validation can also be done in the constructor.

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Feb 2, 2021
@Adirio Adirio changed the title Constructor for Resource ✨ Constructor for Resource Feb 2, 2021
Signed-off-by: Adrian Orive <adrian.orive.oneca@gmail.com>
@Adirio
Copy link
Contributor Author

Adirio commented Feb 2, 2021

/hold cancel

#1974 was merged

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Feb 2, 2021
Copy link
Member

@camilamacedo86 camilamacedo86 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it shows fine for me too.

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Adirio, camilamacedo86

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 3, 2021
@Adirio
Copy link
Contributor Author

Adirio commented Feb 9, 2021

With plugin phase 1.5, it has become apparent that resources should be created by the CLI and injected into the different plugins so that they all refer to the same object and they can make their own modifications. This fact greatly reduces the enhancement that this PR offers, as the creation would not use any of the provided options and later modifications can't be done using options. Closing this PR, if plugin phase 1.5 approach is not followed, it may be reopened.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants