-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
✨ Constructor for Resource #1986
Conversation
/hold Waiting until #1974 is merged so that validation can also be done in the constructor. |
1cbd1a0
to
b4aaf19
Compare
b4aaf19
to
f9c8fb6
Compare
Signed-off-by: Adrian Orive <adrian.orive.oneca@gmail.com>
f9c8fb6
to
89df311
Compare
/hold cancel #1974 was merged |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it shows fine for me too.
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Adirio, camilamacedo86 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
With plugin phase 1.5, it has become apparent that resources should be created by the CLI and injected into the different plugins so that they all refer to the same object and they can make their own modifications. This fact greatly reduces the enhancement that this PR offers, as the creation would not use any of the provided options and later modifications can't be done using options. Closing this PR, if plugin phase 1.5 approach is not followed, it may be reopened. |
Provide a constructor for
Resource
in order to better split the model from the command flag options for each plugin so that third-party can consume this API instead of creating anOptions
object.