-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
deps: bump kubebuilder to v3.0.0-beta.1 #4581
Merged
jmrodri
merged 1 commit into
operator-framework:master
from
Adirio:align-kubebuilder-1.5
Mar 24, 2021
Merged
deps: bump kubebuilder to v3.0.0-beta.1 #4581
jmrodri
merged 1 commit into
operator-framework:master
from
Adirio:align-kubebuilder-1.5
Mar 24, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4ae7fc6
to
c481c10
Compare
hack/generate/samples/internal/go/v3/memcached_with_webhooks.go
Outdated
Show resolved
Hide resolved
This comment has been minimized.
This comment has been minimized.
2d99d1b
to
d95a15d
Compare
2 tasks
d95a15d
to
0b24fd1
Compare
This #4584 (comment) should also be applied here. |
1 task
2e62486
to
741d436
Compare
internal/cmd/operator-sdk/generate/packagemanifests/packagemanifests_test.go
Outdated
Show resolved
Hide resolved
feaeb1e
to
63c80c1
Compare
/hold Holding while I discuss a couples NITs offline with @estroz. |
jmrodri
approved these changes
Mar 24, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
Based on all the discussions in slack I'm okay with this.
Signed-off-by: Adrián Orive <adrian.orive.oneca@gmail.com>
e5134fd
to
99839b9
Compare
/hold cancel |
/lgtm |
estroz
added a commit
to estroz/operator-sdk
that referenced
this pull request
Mar 29, 2021
Signed-off-by: Eric Stroczynski <ericstroczynski@gmail.com>
2 tasks
estroz
added a commit
to estroz/operator-sdk
that referenced
this pull request
Mar 29, 2021
Signed-off-by: Eric Stroczynski <ericstroczynski@gmail.com>
estroz
pushed a commit
that referenced
this pull request
Mar 29, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the change: bump kubebuilder to kubernetes-sigs/kubebuilder@v3.0.0-beta.1, and make plugin API changes.
Motivation for the change: recent changes in kubebuilder.
/area dependency
Checklist
If the pull request includes user-facing changes, extra documentation is required:
changelog/fragments
(seechangelog/fragments/00-template.yaml
)website/content/en/docs