Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deps: bump kubebuilder to v3.0.0-beta.1 #4581

Merged
merged 1 commit into from
Mar 24, 2021

Conversation

Adirio
Copy link
Contributor

@Adirio Adirio commented Feb 24, 2021

Description of the change: bump kubebuilder to kubernetes-sigs/kubebuilder@v3.0.0-beta.1, and make plugin API changes.

Motivation for the change: recent changes in kubebuilder.

/area dependency

Checklist

If the pull request includes user-facing changes, extra documentation is required:

@openshift-ci-robot openshift-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Feb 24, 2021
@Adirio

This comment has been minimized.

@Adirio
Copy link
Contributor Author

Adirio commented Feb 26, 2021

This #4584 (comment) should also be applied here.

@Adirio Adirio force-pushed the align-kubebuilder-1.5 branch 4 times, most recently from 2e62486 to 741d436 Compare March 1, 2021 13:15
@Adirio Adirio force-pushed the align-kubebuilder-1.5 branch 3 times, most recently from feaeb1e to 63c80c1 Compare March 1, 2021 18:19
@Adirio Adirio temporarily deployed to deploy March 24, 2021 10:28 Inactive
@Adirio Adirio temporarily deployed to deploy March 24, 2021 10:28 Inactive
@Adirio Adirio temporarily deployed to deploy March 24, 2021 10:28 Inactive
@Adirio Adirio temporarily deployed to deploy March 24, 2021 10:28 Inactive
@Adirio Adirio temporarily deployed to deploy March 24, 2021 10:28 Inactive
@Adirio Adirio temporarily deployed to deploy March 24, 2021 10:28 Inactive
@Adirio
Copy link
Contributor Author

Adirio commented Mar 24, 2021

/hold

Holding while I discuss a couples NITs offline with @estroz.

@openshift-ci-robot openshift-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 24, 2021
Copy link
Member

@jmrodri jmrodri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Based on all the discussions in slack I'm okay with this.

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Mar 24, 2021
Signed-off-by: Adrián Orive <adrian.orive.oneca@gmail.com>
@openshift-ci-robot openshift-ci-robot removed the lgtm Indicates that a PR is ready to be merged. label Mar 24, 2021
@Adirio Adirio temporarily deployed to deploy March 24, 2021 19:50 Inactive
@Adirio Adirio temporarily deployed to deploy March 24, 2021 19:50 Inactive
@Adirio Adirio temporarily deployed to deploy March 24, 2021 19:50 Inactive
@Adirio Adirio temporarily deployed to deploy March 24, 2021 19:50 Inactive
@Adirio Adirio temporarily deployed to deploy March 24, 2021 19:50 Inactive
@Adirio Adirio temporarily deployed to deploy March 24, 2021 19:50 Inactive
@Adirio
Copy link
Contributor Author

Adirio commented Mar 24, 2021

/hold cancel

@openshift-ci-robot openshift-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 24, 2021
@jmrodri
Copy link
Member

jmrodri commented Mar 24, 2021

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Mar 24, 2021
@jmrodri jmrodri merged commit 1e01436 into operator-framework:master Mar 24, 2021
@Adirio Adirio deleted the align-kubebuilder-1.5 branch March 24, 2021 20:21
estroz added a commit to estroz/operator-sdk that referenced this pull request Mar 29, 2021
Signed-off-by: Eric Stroczynski <ericstroczynski@gmail.com>
estroz added a commit to estroz/operator-sdk that referenced this pull request Mar 29, 2021
Signed-off-by: Eric Stroczynski <ericstroczynski@gmail.com>
estroz pushed a commit that referenced this pull request Mar 29, 2021
Signed-off-by: Eric Stroczynski <ericstroczynski@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants