Create go/v4 plugin with alpha1 level to address changes which are breaking ones for go/v3

[camilamacedo86]

What do you want to happen?

The goal of this task is to:

• Create go/v4 plugin with alpha1 level to address changes which are breaking ones for go/v3

Also, you can check the policy: https://github.com/kubernetes-sigs/kubebuilder/blob/master/VERSIONING.md#introducing-changes-to-plugins.

What is required to:

• Make a copy of https://github.com/kubernetes-sigs/kubebuilder/tree/master/pkg/plugins/golang/v3 to https://github.com/kubernetes-sigs/kubebuilder/tree/master/pkg/plugins/golang/v4
• see that we define the level / version of the plugin in: https://github.com/kubernetes-sigs/kubebuilder/blob/master/pkg/plugins/golang/v3/plugin.go#L29-L31
• Then, rename the plugin. info to go/v4 + ensure that it will be alpha1 version
• We also need to began to scaffold samples for the go/v4 as we do for go/v3 under the testdata, see: https://github.com/kubernetes-sigs/kubebuilder/blob/master/test/testdata/generate.sh

For go/v4 we do not need the sample v1beta1 since we will remove its support. See: #2531

• By latest, we also will need the e2e tests for go/v4 see: https://github.com/kubernetes-sigs/kubebuilder/tree/master/test/e2e/v3

Extra Labels

No response

[Ankit152]

Hey @camilamacedo86 🙂
I would like to work on this issue. Can you assign me this one?

[camilamacedo86]

that is great 👍

/assign @Ankit152

^ done

[Ankit152]

Thank you very much 🙂

[Ankit152]

Hey @NikhilSharmaWe 🙂
Thank you for your interest on this but this issue is assigned to me.

[NikhilSharmaWe]

@Ankit152 Actually I was interested in working on #2531 but we should add new go/v4 plugin before working on that. So I started working on it before you were assigned. Apologies if you were also working on it.

You should join this thread https://kubernetes.slack.com/archives/CAR30FCJZ/p1647679086601079 and we can distribute our work further .

[Ankit152]

@NikhilSharmaWe I totally understand but before moving forward with my assigned issue you could have asked me regarding this.

[Ankit152]

Hey @camilamacedo86 🙂
I think this issue should be assigned to @NikhilSharmaWe as he has done quite a lot of progress with his PR.

[camilamacedo86]

/assign @NikhilSharmaWe

[camilamacedo86]

We discussed this issue in the triage and accepted it but we forgot to add the label.
Adding now

[camilamacedo86]

Based on the latest discussions on the Kubebuider and C+R meetings and the latest finds:

a) To address the kustomize requirements we do not need a new base golang to go v4 alpha plugin. It needs to be done in the kustomize one. See: #2583

b) Then, shows that we have not enough requirements yet to justify a new base go v4 plugin. The only things that we could address on this one are:

• Upgrade ginkgo to v2 for go/v4 plugin #2532
• For go/v4, remove the option to create v1beta1 CRD and Webhooks #2531

So that, at this moment it would add an extra cost for us to keep maintaining the projects which are not justified by the value that it brings.

c) The only thing that we might want to still add currently would be a new go/v4-alpha plugin to help users begin to use the kustomize/v2-alpha after the PR #2583 get merged.

That would mean

we only change the cli to have:

	gov4Bundle, _ := plugin.NewBundle(golang.DefaultNameQualifier, plugin.Version{Number: 4, Stage: stage.Alpha},
		kustomizecommonv2.Plugin{}, // new alpha plugin
		golangv3.Plugin{}, // current language based plugin 
	)

And the test data scaffolds for this one.
PS.: Looking in the PR: #2547 that would mean not add all files under: https://github.com/kubernetes-sigs/kubebuilder/tree/master/pkg/plugins/golang/v4

However, IMO would be nice if we tried to do the above ^ change and discuss it with the other maintainers as well.

In this way, @NikhilSharmaWe I would like to recommend:
a) Let's wait for the PR #2583 to get merged
b) Then, I'd suggest we change your PR to #2547 as described above so that, we can easily show the results and bring this topic for others be able to opnieted about its pros and cons.

c/c @varshaprasad96 @rashmigottipati @ryantking