-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve the error output of the declarative plugin #2563
Comments
/assign |
Could you please improve the description and add: |
The problem occurs when people try to use the declarative plugin to initialise a new project for example, the following command looks like it should be correct
But the user will get the following error
Obviously the domain flag does exist, the real problem is, that the declarative plugin can't be used alone - if we use the same command but add another plugin:
then the command works. But this might not be obvious to a new user and the error in this case is not helpfull at all. Idealy we would want an error here indicating that the kubebuilder plugin can't be used alone. |
Thank you for the clarifications. See that each plugin must know what is required for its self-work and not about other plugins explicitly. For the error: It happens because the declarative plugin does not have this flag implemented at all. However, I understand that we might have a hall for improvements here. We might be able to improve the plugin helpers, errors and etc in order to clarify what is or not available, what is a requirement or not for this plugin as improving its messages. |
Yes I understand, I already tried to work on this and saw that it wasn't as simple as adjusting just the plugin code itself. That being sad, I would still be looking further into this and see if I can make some improvements - just going to take longer than I originally anticipated. |
@mariuskimmina can you please propose the improvements you are suggesting to handle such scenarios? |
So, I think the problem is that when we are using the declarative plugin alone, such as an in this command
Which results in the error |
@camilamacedo86 Do we need to work on this? If yes, do we want to:
|
Hi @NikhilSharmaWe, You do not need to any issue :-). However, if you want to contribute to this one, I am not sure how would be the best approach to address improvements regarding this case. As part of this issue, we are still required to do an assessment and see if we could propose any improvement/change to address this one. It might also involve seeing if the solution approach could be a more generic design where we could allow the definition, for example, pre-requirements for the plugins. (not sure if that would be the case) |
The Kubernetes project currently lacks enough contributors to adequately respond to all issues and PRs. This bot triages issues and PRs according to the following rules:
You can:
Please send feedback to sig-contributor-experience at kubernetes/community. /lifecycle stale |
The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs. This bot triages issues and PRs according to the following rules:
You can:
Please send feedback to sig-contributor-experience at kubernetes/community. /lifecycle rotten |
The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs. This bot triages issues according to the following rules:
You can:
Please send feedback to sig-contributor-experience at kubernetes/community. /close not-planned |
@k8s-triage-robot: Closing this issue, marking it as "Not Planned". In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
What do you want to happen?
As discussed in #2562 the error output of the
declarative
plugin could be improved.Errors such as:
Can be confusing to the user.
I'll work on this myself, just creating the issue to track the work.
Extra Labels
No response
The text was updated successfully, but these errors were encountered: