Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove the trailing space from the comments and the reduce the blank space #2716

Closed
camilamacedo86 opened this issue Jun 8, 2022 · 3 comments · Fixed by #2763
Closed

remove the trailing space from the comments and the reduce the blank space #2716

camilamacedo86 opened this issue Jun 8, 2022 · 3 comments · Fixed by #2763
Labels
kind/bug Categorizes issue or PR as related to a bug.
Milestone

Comments

@camilamacedo86
Copy link
Member

What broke? What's expected?

It is regarding the changes made in: #2596

The goal is only to remove the trailing space ( space at the of the comments ) and reduce the space between # to the text from 4 to 2. The comment should be updated with:

# leaderElectionReleaseOnCancel defines if the leader should step down volume
# when the Manager ends. This requires the binary to immediately end when the
# Manager is stopped, otherwise, this setting is unsafe. Setting this significantly
# speeds up voluntary leader transitions as the new leader doesn't have to wait
# LeaseDuration time first.
# In the default scaffold provided, the program ends immediately after
# the manager stops, so would be fine to enable this option. However,
# if you are doing or is intended to do any operation such as perform cleanups
# after the manager stops then its usage might be unsafe.
# leaderElectionReleaseOnCancel: true

Why?

Molecule tests which have a lint check have been failing because of the format on SDK. operator-framework/operator-sdk#5838

Reproducing this issue

Call the molecule tests as it is done for the advanced mock scenario on SDK with these changes

KubeBuilder (CLI) Version

master

PROJECT version

No response

Plugin versions

No response

Other versions

No response

Extra Labels

No response

@camilamacedo86 camilamacedo86 added the kind/bug Categorizes issue or PR as related to a bug. label Jun 8, 2022
@everettraven
Copy link
Contributor

resolved with #2721

@camilamacedo86
Copy link
Member Author

@everettraven that is another place we did not solve this one with #2721

@everettraven
Copy link
Contributor

Oops, sorry I read the issue to quickly. Thanks @camilamacedo86 !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug Categorizes issue or PR as related to a bug.
Projects
None yet
2 participants