Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

馃尡 remove the trailing-spaces #2721

Merged
merged 1 commit into from
Jun 13, 2022
Merged

馃尡 remove the trailing-spaces #2721

merged 1 commit into from
Jun 13, 2022

Conversation

camilamacedo86
Copy link
Member

@camilamacedo86 camilamacedo86 commented Jun 13, 2022 •
edited
Loading

description
馃尡 remove the trailing-spaces

Motivation
Ansible operators fails in in the molecule tests with

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Jun 13, 2022
everettraven
everettraven approved these changes Jun 13, 2022
View reviewed changes
Copy link
Contributor

@everettraven everettraven left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: camilamacedo86, everettraven

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@camilamacedo86
Copy link
Member Author

/retest-required

2 similar comments
@camilamacedo86
Copy link
Member Author

/retest-required

@camilamacedo86
Copy link
Member Author

/retest-required

@camilamacedo86 camilamacedo86 force-pushed the trailing-spaces branch 2 times, most recently from 4366931 to a348a76 Compare June 13, 2022 21:03
@kubernetes-sigs kubernetes-sigs deleted a comment from k8s-ci-robot Jun 13, 2022
@camilamacedo86 camilamacedo86 added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 13, 2022
@k8s-ci-robot
Copy link
Contributor

@camilamacedo86: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-kubebuilder-e2e-k8s-1-17-11 68a33a5 link false /test pull-kubebuilder-e2e-k8s-1-17-11
pull-kubebuilder-e2e-k8s-1-19-4 68a33a5 link false /test pull-kubebuilder-e2e-k8s-1-19-4
pull-kubebuilder-e2e-k8s-1-18-8 68a33a5 link false /test pull-kubebuilder-e2e-k8s-1-18-8
pull-kubebuilder-e2e-k8s-1-24-1 68a33a5 link false /test pull-kubebuilder-e2e-k8s-1-24-1

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@k8s-ci-robot k8s-ci-robot merged commit 7a05e3d into kubernetes-sigs:master Jun 13, 2022
@camilamacedo86 camilamacedo86 deleted the trailing-spaces branch June 13, 2022 22:48
@everettraven everettraven mentioned this pull request Jun 15, 2022
Closed
@everettraven everettraven mentioned this pull request Jun 24, 2022
Closed
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@everettraven everettraven everettraven approved these changes

@joelanford joelanford Awaiting requested review from joelanford

@pwittrock pwittrock Awaiting requested review from pwittrock

Assignees
No one assigned
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@camilamacedo86 @k8s-ci-robot @everettraven