Makefile scaffolding should generate target to install Kustomize with go install #2822

erikgb · 2022-07-12T20:05:31Z

What do you want to happen?

Since version 4.5.2, Kustomize supports installation with go install, ref. kubernetes-sigs/kustomize#3618. As a workaround we used the official install script in #2486.

Motivation: Even if using the official Kustomize install script, I try to avoid executing remotely downloaded shell scripts.

Extra Labels

/kind cleanup

The text was updated successfully, but these errors were encountered:

camilamacedo86 · 2022-07-12T21:46:21Z

Hi @erikgb,

By default Kubebuilder scaffolds the Bundle go/v3 which cannot begin to use kustomize v4. It is a breaking change for the stable plugin. More info

Then, we cannot get the kustomize v3 used in the default scaffolds with go install. We can only change it for the next version (go/v4-alpha) which is using this version. In this way, I am adding this one to the go/v4 milestone.

To know more about the plugins see: https://book.kubebuilder.io/plugins/plugins.html

…munity in the layout - Add a new golang language base plugin (base.go/v4) - Change the go/v4-alpha plugin to use the new base - Address the layout changes requirements for go/v4. Now, the api and controllers are under the pkg dir. - Change the Makefile to install kustomize with go install - Remove crdVersion and webhook versions that is not supported and should no longer be served. Closes: kubernetes-sigs#932 Closes: kubernetes-sigs#2531 Closes: kubernetes-sigs#2822

…munity in the layout - Add a new golang language base plugin (base.go/v4) - Change the go/v4-alpha plugin to use the new base - Address the layout changes requirements for go/v4. Now, the api and controllers are under the pkg dir. - Change the Makefile to install kustomize with go install - Remove crdVersion and webhook versions that is not supported and should no longer be served. Closes: kubernetes-sigs#932 Closes: kubernetes-sigs#2822

k8s-triage-robot · 2022-10-10T21:59:56Z

The Kubernetes project currently lacks enough contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

After 90d of inactivity, lifecycle/stale is applied
After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

Mark this issue or PR as fresh with /remove-lifecycle stale
Mark this issue or PR as rotten with /lifecycle rotten
Close this issue or PR with /close
Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

k8s-triage-robot · 2023-01-20T09:15:28Z

The Kubernetes project currently lacks enough contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

After 90d of inactivity, lifecycle/stale is applied
After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

Mark this issue or PR as fresh with /remove-lifecycle stale
Mark this issue or PR as rotten with /lifecycle rotten
Close this issue or PR with /close
Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

erikgb · 2023-01-20T09:23:29Z

/remove-lifecycle stale

Still relevant

Sajiyah-Salat · 2023-01-31T12:21:25Z

Hello @camilamacedo86 from above conversation it does not look like a good first issue. you have added good first issue label after long time. Can I know how this is a good first issue?

camilamacedo86 · 2023-02-11T15:17:58Z

Yes, you can. Please feel free to check this one.

Sajiyah-Salat · 2023-02-12T00:53:26Z

I think there should be a link in this keyword.

camilamacedo86 · 2023-02-12T17:58:27Z

The changes must be done in : https://github.com/kubernetes-sigs/kubebuilder/blob/master/pkg/plugins/golang/v4/scaffolds/internal/templates/makefile.go#L198-L206

You will do the change and run make generate to ensure that all samples under testdata are updated properly to push the PR.

Sajiyah-Salat · 2023-02-13T01:31:30Z

The above info was a little hard to process. I got that go get can't be used we need to add go install in updated version of kubebuilder. controller-gen have go install. Do I need to change like that?

lakshya8066 · 2023-02-13T14:52:59Z

/assign

ashutosh887 · 2023-02-26T09:40:57Z

@lakshya8066 If you are not able to resolve this, I would like to take this up @camilamacedo86

Sajiyah-Salat · 2023-02-27T02:15:11Z

The above info was a little hard to process. I got that go get can't be used we need to add go install in updated version of kubebuilder. controller-gen have go install. Do I need to change like that?

it may sound dumb. but can I get reply or reviews on this. i am eager to contribute here. help me.

erikgb · 2023-02-27T07:34:03Z

The above info was a little hard to process. I got that go get can't be used we need to add go install in updated version of kubebuilder. controller-gen have go install. Do I need to change like that?

it may sound dumb. but can I get reply or reviews on this. i am eager to contribute here. help me.

Not sure if I understand the question, but I assume using a similar approach that for the other CLI tools installations using go install would work (like controller-gen).

Sajiyah-Salat · 2023-02-28T02:10:12Z

Thank you @erikgb for your reply.

Sajiyah-Salat · 2023-03-07T11:37:40Z

The above info was a little hard to process. I got that go get can't be used we need to add go install in updated version of kubebuilder. controller-gen have go install. Do I need to change like that?

Hello @camilamacedo86 need your reviews.

camilamacedo86 · 2023-03-07T12:00:54Z

The scope for this task is only change how we obtain / install kustomize.
The idea is to use go install instead of the shell script only for go/v4 scaffold.

See the target:

https://github.com/kubernetes-sigs/kubebuilder/blob/master/testdata/project-v4/Makefile#L138-L146

Then, see where the code changes should be done:

https://github.com/kubernetes-sigs/kubebuilder/blob/master/pkg/plugins/golang/v4/scaffolds/internal/templates/makefile.go#L198-L206

Therefore, we should not touch in the controller-gen target at all to do this one.
I am not sure if we can use go install to obtain controller-gen but anyway that is not part of the scope of this issue.

You can check here: https://kubectl.docs.kubernetes.io/installation/kustomize/source/ how we can install kustomize using the go install instead.

lauchokyip · 2023-05-08T14:17:52Z

/assign

Will tackle this one 😃, expecting a PR within 2 weeks

erikgb added the kind/feature Categorizes issue or PR as related to a new feature. label Jul 12, 2022

k8s-ci-robot added the kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. label Jul 12, 2022

camilamacedo86 added this to the go/v4 milestone Jul 12, 2022

This was referenced Oct 1, 2022

⚠️ go/v4-alpha: change the layout to follow Golang Standards #2985

Merged

✨ Add new Golang base for go/v4-alpha with changes requested by the community in the layout #2986

Closed

k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Oct 10, 2022

camilamacedo86 removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Oct 22, 2022

k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jan 20, 2023

k8s-ci-robot removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jan 20, 2023

camilamacedo86 added the priority/backlog Higher priority than priority/awaiting-more-evidence. label Feb 11, 2023

k8s-ci-robot assigned lakshya8066 Feb 13, 2023

k8s-ci-robot assigned lauchokyip May 8, 2023

lauchokyip mentioned this issue May 9, 2023

✨ Updated Makefile to support go install kustomize #3398

Merged

k8s-ci-robot closed this as completed in #3398 May 12, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Makefile scaffolding should generate target to install Kustomize with go install #2822

Makefile scaffolding should generate target to install Kustomize with go install #2822

erikgb commented Jul 12, 2022

camilamacedo86 commented Jul 12, 2022 •

edited

Loading

k8s-triage-robot commented Oct 10, 2022

k8s-triage-robot commented Jan 20, 2023

erikgb commented Jan 20, 2023

Sajiyah-Salat commented Jan 31, 2023

camilamacedo86 commented Feb 11, 2023

Sajiyah-Salat commented Feb 12, 2023

camilamacedo86 commented Feb 12, 2023 •

edited

Loading

Sajiyah-Salat commented Feb 13, 2023

lakshya8066 commented Feb 13, 2023

ashutosh887 commented Feb 26, 2023

Sajiyah-Salat commented Feb 27, 2023

erikgb commented Feb 27, 2023

Sajiyah-Salat commented Feb 28, 2023

Sajiyah-Salat commented Mar 7, 2023

camilamacedo86 commented Mar 7, 2023 •

edited

Loading

lauchokyip commented May 8, 2023 •

edited

Loading

Makefile scaffolding should generate target to install Kustomize with go install #2822

Makefile scaffolding should generate target to install Kustomize with go install #2822

Comments

erikgb commented Jul 12, 2022

What do you want to happen?

Extra Labels

camilamacedo86 commented Jul 12, 2022 • edited Loading

k8s-triage-robot commented Oct 10, 2022

k8s-triage-robot commented Jan 20, 2023

erikgb commented Jan 20, 2023

Sajiyah-Salat commented Jan 31, 2023

camilamacedo86 commented Feb 11, 2023

Sajiyah-Salat commented Feb 12, 2023

camilamacedo86 commented Feb 12, 2023 • edited Loading

Sajiyah-Salat commented Feb 13, 2023

lakshya8066 commented Feb 13, 2023

ashutosh887 commented Feb 26, 2023

Sajiyah-Salat commented Feb 27, 2023

erikgb commented Feb 27, 2023

Sajiyah-Salat commented Feb 28, 2023

Sajiyah-Salat commented Mar 7, 2023

camilamacedo86 commented Mar 7, 2023 • edited Loading

lauchokyip commented May 8, 2023 • edited Loading

camilamacedo86 commented Jul 12, 2022 •

edited

Loading

camilamacedo86 commented Feb 12, 2023 •

edited

Loading

camilamacedo86 commented Mar 7, 2023 •

edited

Loading

lauchokyip commented May 8, 2023 •

edited

Loading