-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Makefile scaffolding should generate target to install Kustomize with go install #2822
Comments
Hi @erikgb, By default Kubebuilder scaffolds the Bundle go/v3 which cannot begin to use kustomize v4. It is a breaking change for the stable plugin. More info Then, we cannot get the kustomize v3 used in the default scaffolds with go install. We can only change it for the next version (go/v4-alpha) which is using this version. In this way, I am adding this one to the go/v4 milestone. To know more about the plugins see: https://book.kubebuilder.io/plugins/plugins.html |
…munity in the layout - Add a new golang language base plugin (base.go/v4) - Change the go/v4-alpha plugin to use the new base - Address the layout changes requirements for go/v4. Now, the api and controllers are under the pkg dir. - Change the Makefile to install kustomize with go install - Remove crdVersion and webhook versions that is not supported and should no longer be served. Closes: kubernetes-sigs#932 Closes: kubernetes-sigs#2531 Closes: kubernetes-sigs#2822
…munity in the layout - Add a new golang language base plugin (base.go/v4) - Change the go/v4-alpha plugin to use the new base - Address the layout changes requirements for go/v4. Now, the api and controllers are under the pkg dir. - Change the Makefile to install kustomize with go install - Remove crdVersion and webhook versions that is not supported and should no longer be served. Closes: kubernetes-sigs#932 Closes: kubernetes-sigs#2531 Closes: kubernetes-sigs#2822
…munity in the layout - Add a new golang language base plugin (base.go/v4) - Change the go/v4-alpha plugin to use the new base - Address the layout changes requirements for go/v4. Now, the api and controllers are under the pkg dir. - Change the Makefile to install kustomize with go install - Remove crdVersion and webhook versions that is not supported and should no longer be served. Closes: kubernetes-sigs#932 Closes: kubernetes-sigs#2531 Closes: kubernetes-sigs#2822
…munity in the layout - Add a new golang language base plugin (base.go/v4) - Change the go/v4-alpha plugin to use the new base - Address the layout changes requirements for go/v4. Now, the api and controllers are under the pkg dir. - Change the Makefile to install kustomize with go install - Remove crdVersion and webhook versions that is not supported and should no longer be served. Closes: kubernetes-sigs#932 Closes: kubernetes-sigs#2531 Closes: kubernetes-sigs#2822
…munity in the layout - Add a new golang language base plugin (base.go/v4) - Change the go/v4-alpha plugin to use the new base - Address the layout changes requirements for go/v4. Now, the api and controllers are under the pkg dir. - Change the Makefile to install kustomize with go install - Remove crdVersion and webhook versions that is not supported and should no longer be served. Closes: kubernetes-sigs#932 Closes: kubernetes-sigs#2531 Closes: kubernetes-sigs#2822
…munity in the layout - Add a new golang language base plugin (base.go/v4) - Change the go/v4-alpha plugin to use the new base - Address the layout changes requirements for go/v4. Now, the api and controllers are under the pkg dir. - Change the Makefile to install kustomize with go install - Remove crdVersion and webhook versions that is not supported and should no longer be served. Closes: kubernetes-sigs#932 Closes: kubernetes-sigs#2531 Closes: kubernetes-sigs#2822
…munity in the layout - Add a new golang language base plugin (base.go/v4) - Change the go/v4-alpha plugin to use the new base - Address the layout changes requirements for go/v4. Now, the api and controllers are under the pkg dir. - Change the Makefile to install kustomize with go install - Remove crdVersion and webhook versions that is not supported and should no longer be served. Closes: kubernetes-sigs#932 Closes: kubernetes-sigs#2531 Closes: kubernetes-sigs#2822
…munity in the layout - Add a new golang language base plugin (base.go/v4) - Change the go/v4-alpha plugin to use the new base - Address the layout changes requirements for go/v4. Now, the api and controllers are under the pkg dir. - Change the Makefile to install kustomize with go install - Remove crdVersion and webhook versions that is not supported and should no longer be served. Closes: kubernetes-sigs#932 Closes: kubernetes-sigs#2531 Closes: kubernetes-sigs#2822
…munity in the layout - Add a new golang language base plugin (base.go/v4) - Change the go/v4-alpha plugin to use the new base - Address the layout changes requirements for go/v4. Now, the api and controllers are under the pkg dir. - Change the Makefile to install kustomize with go install - Remove crdVersion and webhook versions that is not supported and should no longer be served. Closes: kubernetes-sigs#932 Closes: kubernetes-sigs#2531 Closes: kubernetes-sigs#2822
…munity in the layout - Add a new golang language base plugin (base.go/v4) - Change the go/v4-alpha plugin to use the new base - Address the layout changes requirements for go/v4. Now, the api and controllers are under the pkg dir. - Change the Makefile to install kustomize with go install - Remove crdVersion and webhook versions that is not supported and should no longer be served. Closes: kubernetes-sigs#932 Closes: kubernetes-sigs#2531 Closes: kubernetes-sigs#2822
…munity in the layout - Add a new golang language base plugin (base.go/v4) - Change the go/v4-alpha plugin to use the new base - Address the layout changes requirements for go/v4. Now, the api and controllers are under the pkg dir. - Change the Makefile to install kustomize with go install - Remove crdVersion and webhook versions that is not supported and should no longer be served. Closes: kubernetes-sigs#932 Closes: kubernetes-sigs#2531 Closes: kubernetes-sigs#2822
…munity in the layout - Add a new golang language base plugin (base.go/v4) - Change the go/v4-alpha plugin to use the new base - Address the layout changes requirements for go/v4. Now, the api and controllers are under the pkg dir. - Change the Makefile to install kustomize with go install - Remove crdVersion and webhook versions that is not supported and should no longer be served. Closes: kubernetes-sigs#932 Closes: kubernetes-sigs#2822
…munity in the layout - Add a new golang language base plugin (base.go/v4) - Change the go/v4-alpha plugin to use the new base - Address the layout changes requirements for go/v4. Now, the api and controllers are under the pkg dir. - Change the Makefile to install kustomize with go install - Remove crdVersion and webhook versions that is not supported and should no longer be served. Closes: kubernetes-sigs#932 Closes: kubernetes-sigs#2822
The Kubernetes project currently lacks enough contributors to adequately respond to all issues and PRs. This bot triages issues and PRs according to the following rules:
You can:
Please send feedback to sig-contributor-experience at kubernetes/community. /lifecycle stale |
The Kubernetes project currently lacks enough contributors to adequately respond to all issues and PRs. This bot triages issues and PRs according to the following rules:
You can:
Please send feedback to sig-contributor-experience at kubernetes/community. /lifecycle stale |
/remove-lifecycle stale Still relevant |
Hello @camilamacedo86 from above conversation it does not look like a good first issue. you have added good first issue label after long time. Can I know how this is a good first issue? |
Yes, you can. Please feel free to check this one. |
I think there should be a link in |
The changes must be done in : https://github.com/kubernetes-sigs/kubebuilder/blob/master/pkg/plugins/golang/v4/scaffolds/internal/templates/makefile.go#L198-L206 You will do the change and run |
The above info was a little hard to process. I got that |
/assign |
@lakshya8066 If you are not able to resolve this, I would like to take this up @camilamacedo86 |
it may sound dumb. but can I get reply or reviews on this. i am eager to contribute here. help me. |
Not sure if I understand the question, but I assume using a similar approach that for the other CLI tools installations using |
Thank you @erikgb for your reply. |
Hello @camilamacedo86 need your reviews. |
The scope for this task is only change how we obtain / install kustomize. See the target: Then, see where the code changes should be done: Therefore, we should not touch in the controller-gen target at all to do this one. You can check here: https://kubectl.docs.kubernetes.io/installation/kustomize/source/ how we can install kustomize using the go install instead. |
/assign Will tackle this one 😃, expecting a PR within 2 weeks |
What do you want to happen?
Since version 4.5.2, Kustomize supports installation with
go install
, ref. kubernetes-sigs/kustomize#3618. As a workaround we used the official install script in #2486.Motivation: Even if using the official Kustomize install script, I try to avoid executing remotely downloaded shell scripts.
Extra Labels
/kind cleanup
The text was updated successfully, but these errors were encountered: