-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Docs] Document how to record events #2897
Comments
Also, it's probably better to recommend using the controller-runtime recorder over the raw client recorder: https://github.com/kubernetes-sigs/controller-runtime/blob/master/pkg/recorder/recorder.go |
@AlmogBaku: The label(s) In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Following is some relevant info which would be important we cover in the doc: (IMO) we could add a warning with: Events should be raised in certain circumstances only and following this guideline acctually is not a good practice. See what the Kubernetes APIs convention describes when using them here: https://github.com/kubernetes/community/blob/master/contributors/devel/sig-architecture/api-conventions.md#events Also, we can share how to implement the solution to raise an event:
Then, we can also create a note to let users know that the new deploy-image plugin raises events and can be used as an example:
Note that we have a doc in the old book version. So, we might use this content as a base and just ensure that we have the info properly updated: https://book-v1.book.kubebuilder.io/beyond_basics/creating_events.html By last, I think we could add it under the Reference section. |
I would like to work on this, /assign |
Hi @mjlshen, Are you working on this one? If you need help please feel free to ping your questions into the kubebuilder slack channel. |
Hi @camilamacedo86! Sorry, yes I started - then got sidetracked - will pick this up again |
The Kubernetes project currently lacks enough contributors to adequately respond to all PRs. This bot triages PRs according to the following rules:
You can:
Please send feedback to sig-contributor-experience at kubernetes/community. /lifecycle stale |
/remove-lifecycle stale |
/remove-lifecycle stale |
Hello @mjlshen can I take this on? |
I would like to work on this @camilamacedo86 /assign |
@AlmogBaku Please guide me how should I proceed? |
Hey @ashutosh887 if you want we can work together. |
take a look at how I do at Raptor.ml In general, you should inject the event recorder to the Reconciler when initializing it, then record events |
hello @AlmogBaku, in v1 docs it is given perfectly. I dont have depth so I dont know which things need to be updated. morever I have questions regarding to place a record event file. i think I should just open a pr with v1 doc record event file and after your reviews and suggestion we can make it ready for current version? |
/cc @camilamacedo86 |
Yes, we can start by adding the content from v1 |
Sure I've started working on it @camilamacedo86 |
Hello @ashutosh887 are you still working on this. If yes, please link the pr. |
Yes I'm willing to take this forward @Sajiyah-Salat |
Have you made a pr |
The video you suggested is of v1. do you think we should add that? |
It is done : https://book.kubebuilder.io/reference/raising-events Closing this one. |
What do you want to happen?
Following up on: #2684 (comment)
As discussed in the meeting, we think it might be a good idea to add a section about event recording to the documentation, similar to what we had in v1.
Extra Labels
No response
The text was updated successfully, but these errors were encountered: