Update golang version and kube-builder

[quentinalbertone]

What broke? What's expected?

Hi
I recently updated golang on my computer from 1.17 to 1.19,
during the process I also updated the version of kube-builder (I just reinstalled kubebuilder) from 3.3 to 3.7.
But now I cannot generate code containing DeepCopy, DeepCopyInto, and DeepCopyObject method implementations.

$> make generate
my_project_path/bin/controller-gen object:headerFile="hack/boilerplate.go.txt" paths="./..."
/usr/local/Cellar/go/1.19.1/libexec/src/sync/atomic/type.go:39:16: expected ']', found any
/usr/local/Cellar/go/1.19.1/libexec/src/sync/atomic/type.go:39:19: expected ';', found ']'
/usr/local/Cellar/go/1.19.1/libexec/src/sync/atomic/type.go:39:19: expected type, found ']'
/usr/local/Cellar/go/1.19.1/libexec/src/sync/atomic/type.go:45:34: expected declaration, found 'return'
/usr/local/Cellar/go/1.19.1/libexec/src/sync/atomic/type.go:39:16: expected ']', found any
/usr/local/Cellar/go/1.19.1/libexec/src/sync/atomic/type.go:39:19: expected ';', found ']'
/usr/local/Cellar/go/1.19.1/libexec/src/sync/atomic/type.go:39:19: expected type, found ']'
/usr/local/Cellar/go/1.19.1/libexec/src/sync/atomic/type.go:45:34: expected declaration, found 'return'
/usr/local/Cellar/go/1.19.1/libexec/src/sync/atomic/type.go:39:16: expected ']', found any
/usr/local/Cellar/go/1.19.1/libexec/src/sync/atomic/type.go:39:19: expected ';', found ']'
/usr/local/Cellar/go/1.19.1/libexec/src/sync/atomic/type.go:39:19: expected type, found ']'
/usr/local/Cellar/go/1.19.1/libexec/src/sync/atomic/type.go:45:34: expected declaration, found 'return'
Error: not all generators ran successfully
run `controller-gen object:headerFile=hack/boilerplate.go.txt paths=./... -w` to see all available markers, or `controller-gen object:headerFile=hack/boilerplate.go.txt paths=./... -h` for usage
make: *** [generate] Error 1

I suppose that it's link to this field in my struct

// +kubebuilder:validation:Optional
// +mapType:=atomic
// Specifies the node in which the capture must be deployed
// https://kubernetes.io/docs/concepts/scheduling-eviction/assign-pod-node/#nodeselector
NodeSelector map[string]string `json:"nodeSelector,omitempty"`

I'm pretty sure everything was alright before the update but I might be wrong

Reproducing this issue

No response

KubeBuilder (CLI) Version

3.3.0

PROJECT version

v3

Plugin versions

layout:
- go.kubebuilder.io/v3

Other versions

$> go version
go version go1.19.1 darwin/amd64

Extra Labels

No response

[camilamacedo86]

That is probably because of the controller-gen version used.
You are now using the latest version of the CLI but your project was scaffolded using old versions.
I would recommend you upgrade the controller-gen version used (see your Makefile file) as they go.mod deps as you can check in the samples for the tag used, see:

• Go.mod
  

  kubebuilder/testdata/project-v3/go.mod

  Lines 3 to 12 in 3bfc84e

  	go 1.19
  	require (
  	github.com/onsi/ginkgo/v2 v2.1.4
  	github.com/onsi/gomega v1.19.0
  	k8s.io/api v0.25.0
  	k8s.io/apimachinery v0.25.0
  	k8s.io/client-go v0.25.0
  	sigs.k8s.io/controller-runtime v0.13.0
  	)

• And the Makefile: https://github.com/kubernetes-sigs/kubebuilder/blob/v3.7.0/testdata/project-v3/Makefile

If the above does not sort out your problem we will need further info (all steps and versions) to reproduce your issue so that we can check and see how that can be solved.

[quentinalbertone]

Thanks I copy past the makefile as well as the go.mod a little go mod tidyand delete the bin directory and it works fine now.

I think it could be a good Idea to offer a way to scaffold again the project.

[camilamacedo86]

Hi @quentinalbertone,

I think it could be a good Idea to offer a way to scaffold again the project.

Yes. That would be great and very desirable if we could have a solution via tooling that could update the projects. See #2068 (comment) and thought about how we could achieve that.

We also have the PR (WIP): https://github.com/kubernetes-sigs/kubebuilder/pull/2895/files but I am not sure if @rumstead has been able to work on it. Please, if you would like to help out please feel free to do so and also propose any other solution that you see for us to achieve this goal.

Regards this issue, I think we could address the need and I am closing this one. However, feel free to re-open if you see that would be required.