Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make explicit that we would like to have the migration from v3 to v4 helped by tooling #2068

Closed
camilamacedo86 opened this issue Mar 8, 2021 · 9 comments
Labels
kind/feature Categorizes issue or PR as related to a new feature. lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Milestone

Comments

@camilamacedo86
Copy link
Member

Description
Make explicit that we would like to have the migration from v3 to v4 helped by tooling

Suggested Solutions

  • Add new plugin interface documented with this information
    OR
  • Add doc which describes that
@camilamacedo86 camilamacedo86 added the kind/feature Categorizes issue or PR as related to a new feature. label Mar 8, 2021
@camilamacedo86 camilamacedo86 added this to the go/v4 milestone Mar 9, 2021
@camilamacedo86 camilamacedo86 added the triage/accepted Indicates an issue or PR is ready to be actively worked on. label Mar 9, 2021
@camilamacedo86
Copy link
Member Author

camilamacedo86 commented Mar 9, 2021

  • The goal of this task is just we keep this in mind and do not forget that we would like to try to do that by tooling when the go/v4 plugin is released.
  • We are unable to discuss how it would get done before v4 exist

@fejta-bot
Copy link

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-contributor-experience at kubernetes/community.
/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jun 7, 2021
@fejta-bot
Copy link

Stale issues rot after 30d of inactivity.
Mark the issue as fresh with /remove-lifecycle rotten.
Rotten issues close after an additional 30d of inactivity.

If this issue is safe to close now please do so with /close.

Send feedback to sig-contributor-experience at kubernetes/community.
/lifecycle rotten

@k8s-ci-robot k8s-ci-robot added lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Jul 7, 2021
@k8s-triage-robot
Copy link

Rotten issues close after 30d of inactivity.
Reopen the issue with /reopen.
Mark the issue as fresh with /remove-lifecycle rotten.

Send feedback to sig-contributor-experience at kubernetes/community.
/close

@k8s-ci-robot
Copy link
Contributor

@k8s-triage-robot: Closing this issue.

In response to this:

Rotten issues close after 30d of inactivity.
Reopen the issue with /reopen.
Mark the issue as fresh with /remove-lifecycle rotten.

Send feedback to sig-contributor-experience at kubernetes/community.
/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@camilamacedo86
Copy link
Member Author

/remove-lifecycle stale

@camilamacedo86 camilamacedo86 added lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness. and removed lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. labels Oct 16, 2021
@camilamacedo86
Copy link
Member Author

camilamacedo86 commented Aug 10, 2022

Suggestion / Idea to move forward with a proposal for this one:

All commands executed with the tool (data) are tracked in the PROJECT file.
(ihmo) it would be desirable to have a command that re-scaffolds all based on that so it could help in the migration process ( like I want to upgrade my project to the latest versions changes )

We would have an alpha command to try to make it where we could inform via a flag the PROJECT file and the --plugins which we would like to use to do the re-scaffold. Then it would mean for example:

$ kubebuilder alpha scaffold --project-config=<inform the path of the PROJECT file> --plugins=go/v4,grafana/alphav1 --output=path

That could result in:

-> create a directory with the project name
-> call the tool to init the project with the plugins --plugins=go/v4,grafana/alphav1
-> call edit subCommans for edit the project ( example if multigroup be enabled )
-> call create API to create all APIs and controllers scaffold (we also need to check if the api was not scaffolded with for example a specific plugin like deploy-image/alphav1)
-> call create webhook to create the webhooks scaffold as well

That also can lead to future changes/additions to the PROJECT file in case we discover that we are missing info to be tracked there.

@camilamacedo86
Copy link
Member Author

camilamacedo86 commented Oct 7, 2022

Hi @rumstead,

See a draft about how I thought that we could achieve this goal: #3007

@camilamacedo86
Copy link
Member Author

Close this one because we are working a design proposal for this scenario: #3221

we can have an issue as follow-up afterwords where we can better describe what / how that should be done.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/feature Categorizes issue or PR as related to a new feature. lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
None yet
4 participants