-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WIP] ✨: Adding ability to re-scaffold existing projects #2877
Conversation
Welcome @rumstead! |
Hi @rumstead. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: rumstead The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
) | ||
|
||
// NewCommand return a new scaffold command | ||
func (c *CLI) newScaffoldCmd() *cobra.Command { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This feels like it should be in the alpha
folder but since I believe I need methods from CLI
I cannot use a different package.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@camilamacedo86 looking for some guidance here. Since the scaffold
command will essentially do an init
+ edit
+ create
, I need access to thecli
package.
EDIT: I could create an instance of CLI
in the scaffold command but that would be a circular dependency since a CLI instance creates a scaffold
command.
Closes #2068
Relevant discussion
Description
Add tooling to help migrate existing projects to newer versions of scaffolding.