Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci merged a PR even though the test failed #3083

Closed
coriaedu opened this issue Nov 17, 2022 · 3 comments · Fixed by kubernetes/test-infra#28121
Closed

ci merged a PR even though the test failed #3083

coriaedu opened this issue Nov 17, 2022 · 3 comments · Fixed by kubernetes/test-infra#28121
Labels
kind/bug Categorizes issue or PR as related to a bug. priority/critical-urgent Highest priority. Must be actively worked on as someone's top priority right now.

Comments

@coriaedu
Copy link
Contributor

coriaedu commented Nov 17, 2022 •
edited

What broke? What's expected?

At issue #3077, the k8s-ci-robot merged the pulled request even though testing failed, as detailed here: #3077 (comment)

Opening an issue per request of @camilamacedo86 (#3079 (comment)) to do a postmortem

Reproducing this issue

No response

KubeBuilder (CLI) Version

N/A

PROJECT version

No response

Plugin versions

No response

Other versions

No response

Extra Labels

No response
@coriaedu coriaedu added the kind/bug Categorizes issue or PR as related to a bug. label Nov 17, 2022
@camilamacedo86
Copy link
Member

We need to check the configurations. Seems that are not tests configured as required tests when should be.

@camilamacedo86 camilamacedo86 added the priority/critical-urgent Highest priority. Must be actively worked on as someone's top priority right now. label Nov 17, 2022
@camilamacedo86
Copy link
Member

Hi @coriaedu,

The problem is here: https://github.com/kubernetes/test-infra/blob/master/config/jobs/kubernetes-sigs/kubebuilder/kubebuilder-presubmits.yaml#L25. We need to update this optional:true with false instead.

Would you like to contribute with this one?

c/c@everettraven

@coriaedu
Copy link
Contributor Author

@camilamacedo86 sure. I will create PR to change that value

@coriaedu coriaedu mentioned this issue Nov 28, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
kind/bug Categorizes issue or PR as related to a bug. priority/critical-urgent Highest priority. Must be actively worked on as someone's top priority right now.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

make pull-kubebuilder-e2e-k8s-1-25-0 mandatory coriaedu/test-infra
2 participants
@coriaedu @camilamacedo86