✨ add version check for makefile template tools #3077
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Prevent running controller-gen and kustomize commands with a version that does not match the one specified in the corresponding CONTROLLER_TOOLS_VERSION or KUSTOMIZE_VERSION vars Addresses kubernetes-sigs#3068
|
|
|
Welcome @coriaedu! |
k8s-ci-robot
added
cncf-cla: no
|
Hi @coriaedu. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
| test -s $(LOCALBIN)/kustomize || { curl -Ss $(KUSTOMIZE_INSTALL_SCRIPT) | bash -s -- $(subst v,,$(KUSTOMIZE_VERSION)) $(LOCALBIN); } | ||
|
|
||
| .PHONY: controller-gen | ||
| controller-gen: $(CONTROLLER_GEN) ## Download controller-gen locally if necessary. | ||
| $(CONTROLLER_GEN): $(LOCALBIN) | ||
| test -s $(LOCALBIN)/controller-gen || GOBIN=$(LOCALBIN) go install sigs.k8s.io/controller-tools/cmd/controller-gen@$(CONTROLLER_TOOLS_VERSION) | ||
| test -s $(LOCALBIN)/controller-gen && $(LOCALBIN)/controller-gen --version | grep -q $(CONTROLLER_TOOLS_VERSION) || GOBIN=$(LOCALBIN) go install sigs.k8s.io/controller-tools/cmd/controller-gen@$(CONTROLLER_TOOLS_VERSION) |
There was a problem hiding this comment.
could we use
for does not need to scroll to check the code?
k8s-ci-robot
added
cncf-cla: yes
k8s-ci-robot
added
the
do-not-merge/work-in-progress
|
@camilamacedo86 , I converted this to DRAFT while I work on it (excuse the mess... this is my first PR here). |
k8s-ci-robot
added
size/S
coriaedu
changed the title
k8s-ci-robot
added
size/L
added 2 commits
November 16, 2022 14:50
* Updated descriptions for `kustomize` and `controller-gen` targets. * Reformatted `controller-gen` recipe to reduce line length Signed-off-by: Eduardo Coria <emcoria@us.ibm.com>
Signed-off-by: Eduardo Coria <emcoria@us.ibm.com>
k8s-ci-robot
removed
the
do-not-merge/work-in-progress
coriaedu
changed the title
everettraven
approved these changes
Nov 16, 2022
There was a problem hiding this comment.
@coriaedu Thanks for the contribution! These changes look great to me!
/lgtm
k8s-ci-robot
added
the
lgtm
|
/ok-to-test |
k8s-ci-robot
added
ok-to-test
|
@coriaedu: The following tests failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: camilamacedo86, coriaedu, everettraven The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
camilamacedo86
added
the
tide/merge-method-squash
|
@camilamacedo86 @everettraven There was an error in the makefiles that caused an I am about to push a fix for that but this PR was already merged. I was surprised that it was merged with those failing tests :/ Should I create a new PR for that? |
|
@coriaedu Oh interesting, I would have also assumed that the automerge would have been blocked by those as well. Please do open a new PR with the fix. Apologies for the inconvenience! |
No worries! it was my bad after all... I guess the reason for the automerge is because those test are not Required |
This was referenced Nov 16, 2022
camilamacedo86
added a commit
that referenced
this pull request
Dec 6, 2022
* Fix nil pointer in Finalizer example * 📖 fix link for platform support * update kubebuilder core dependencies for k8s 1.25 Signed-off-by: Bryce Palmer <bpalmer@redhat.com> * docs: notify deps install to build book * Update controller-tools version (v0.9.2->v0.10.0) * 🐛 remove duplicate words and fix spelling mistakes * ✨ update kubebuilder kubernetes version * Update the export path of webhook * 📖 fix broken links * fixing the kubebuilder install locally curl request * add dependency bot updates * 🌱 Bump actions/checkout from 2 to 3 Bumps [actions/checkout](https://github.com/actions/checkout) from 2 to 3. - [Release notes](https://github.com/actions/checkout/releases) - [Changelog](https://github.com/actions/checkout/blob/main/CHANGELOG.md) - [Commits](actions/checkout@v2...v3) --- updated-dependencies: - dependency-name: actions/checkout dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com> * 🌱 Bump actions/setup-go from 2 to 3 Bumps [actions/setup-go](https://github.com/actions/setup-go) from 2 to 3. - [Release notes](https://github.com/actions/setup-go/releases) - [Commits](actions/setup-go@v2...v3) --- updated-dependencies: - dependency-name: actions/setup-go dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com> * 🌱 Bump goreleaser/goreleaser-action from 2 to 3 Bumps [goreleaser/goreleaser-action](https://github.com/goreleaser/goreleaser-action) from 2 to 3. - [Release notes](https://github.com/goreleaser/goreleaser-action/releases) - [Commits](goreleaser/goreleaser-action@v2...v3) --- updated-dependencies: - dependency-name: goreleaser/goreleaser-action dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com> * Bump github.com/spf13/afero from 1.6.0 to 1.9.2 Bumps [github.com/spf13/afero](https://github.com/spf13/afero) from 1.6.0 to 1.9.2. - [Release notes](https://github.com/spf13/afero/releases) - [Commits](spf13/afero@v1.6.0...v1.9.2) --- updated-dependencies: - dependency-name: github.com/spf13/afero dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> * Bump github.com/onsi/gomega from 1.19.0 to 1.20.2 Bumps [github.com/onsi/gomega](https://github.com/onsi/gomega) from 1.19.0 to 1.20.2. - [Release notes](https://github.com/onsi/gomega/releases) - [Changelog](https://github.com/onsi/gomega/blob/master/CHANGELOG.md) - [Commits](onsi/gomega@v1.19.0...v1.20.2) --- updated-dependencies: - dependency-name: github.com/onsi/gomega dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> * Bump github.com/sirupsen/logrus from 1.8.1 to 1.9.0 Bumps [github.com/sirupsen/logrus](https://github.com/sirupsen/logrus) from 1.8.1 to 1.9.0. - [Release notes](https://github.com/sirupsen/logrus/releases) - [Changelog](https://github.com/sirupsen/logrus/blob/master/CHANGELOG.md) - [Commits](sirupsen/logrus@v1.8.1...v1.9.0) --- updated-dependencies: - dependency-name: github.com/sirupsen/logrus dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> * Bump k8s.io/apimachinery from 0.25.0 to 0.25.2 Bumps [k8s.io/apimachinery](https://github.com/kubernetes/apimachinery) from 0.25.0 to 0.25.2. - [Release notes](https://github.com/kubernetes/apimachinery/releases) - [Commits](kubernetes/apimachinery@v0.25.0...v0.25.2) --- updated-dependencies: - dependency-name: k8s.io/apimachinery dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> * Bump github.com/gobuffalo/flect from 0.2.5 to 0.3.0 Bumps [github.com/gobuffalo/flect](https://github.com/gobuffalo/flect) from 0.2.5 to 0.3.0. - [Release notes](https://github.com/gobuffalo/flect/releases) - [Commits](gobuffalo/flect@v0.2.5...v0.3.0) --- updated-dependencies: - dependency-name: github.com/gobuffalo/flect dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> * docs: describe e2e test towards plugin Co-authored-by: Camila Macedo <7708031+camilamacedo86@users.noreply.github.com> * 🌱 remove WORKSPACE file commited by mistake * remove unused value * Bump github.com/spf13/cobra from 1.4.0 to 1.5.0 Bumps [github.com/spf13/cobra](https://github.com/spf13/cobra) from 1.4.0 to 1.5.0. - [Release notes](https://github.com/spf13/cobra/releases) - [Commits](spf13/cobra@v1.4.0...v1.5.0) --- updated-dependencies: - dependency-name: github.com/spf13/cobra dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> * Bump github.com/onsi/ginkgo/v2 from 2.1.6 to 2.2.0 Bumps [github.com/onsi/ginkgo/v2](https://github.com/onsi/ginkgo) from 2.1.6 to 2.2.0. - [Release notes](https://github.com/onsi/ginkgo/releases) - [Changelog](https://github.com/onsi/ginkgo/blob/master/CHANGELOG.md) - [Commits](onsi/ginkgo@v2.1.6...v2.2.0) --- updated-dependencies: - dependency-name: github.com/onsi/ginkgo/v2 dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> * Bump github.com/cloudflare/cfssl from 1.5.0 to 1.6.3 Bumps [github.com/cloudflare/cfssl](https://github.com/cloudflare/cfssl) from 1.5.0 to 1.6.3. - [Release notes](https://github.com/cloudflare/cfssl/releases) - [Changelog](https://github.com/cloudflare/cfssl/blob/master/CHANGELOG) - [Commits](cloudflare/cfssl@v1.5.0...v1.6.3) --- updated-dependencies: - dependency-name: github.com/cloudflare/cfssl dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> * update simple-external-plugin-tutorial * update mdbook *⚠️ remove config-gen alpha option * 📖 clarifies plugins available and its usage * 📖 update doc samples * ✨ (go/v4-alpha) : update kustomize version from 4.5.5 to 4.5.7 * ✨ (grafana/v1-alpha) : add custom units for custom grafana dashboards (#2965) :sparkles: add custom units for custom grafana dashboards Signed-off-by: Jirka Kremser <jiri.kremser@gmail.com> Signed-off-by: Jirka Kremser <jiri.kremser@gmail.com> * cleanup: cert-manager and prometheus installs into e2e tests * Apply suggestions from code review * fixed bug for component-config flag updated testdata * Make jmrodri and varsha admins Signed-off-by: jesus m. rodriguez <jesusr@redhat.com> * Bump github.com/onsi/gomega from 1.20.2 to 1.21.1 Bumps [github.com/onsi/gomega](https://github.com/onsi/gomega) from 1.20.2 to 1.21.1. - [Release notes](https://github.com/onsi/gomega/releases) - [Changelog](https://github.com/onsi/gomega/blob/master/CHANGELOG.md) - [Commits](onsi/gomega@v1.20.2...v1.21.1) --- updated-dependencies: - dependency-name: github.com/onsi/gomega dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> * 📖 Updating doc with Installation steps of cert-manager and prometheus (#2982) * Adding installing steps for testing webhooks Adding installing steps for testing webhooks Adding installing steps for testing webhooks Adding installing steps for testing webhooks Adding installing steps for testing webhooks Adding installing steps for testing webhooks Adding installing steps for testing webhooks Adding installing steps for testing webhooks Adding installing steps for testing webhooks Adding installing steps for testing webhooks Adding installing steps for testing webhooks Adding installing steps for testing webhooks * Adding installing steps for testing webhooks * Adding installing steps for testing webhooks * Adding installing steps for testing webhooks * 🐛 : leader-elect arg scaffolded should be scaffolded when component config option is not used (#3013) * updated templates for component config * updates * update * update revert main.go * update revert main.go * revert changes and go thru docs once * Update make build cmd with manifests * Bump github.com/spf13/cobra from 1.5.0 to 1.6.0 Bumps [github.com/spf13/cobra](https://github.com/spf13/cobra) from 1.5.0 to 1.6.0. - [Release notes](https://github.com/spf13/cobra/releases) - [Commits](spf13/cobra@v1.5.0...v1.6.0) --- updated-dependencies: - dependency-name: github.com/spf13/cobra dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> * Bump golang.org/x/text from 0.3.7 to 0.4.0 Bumps [golang.org/x/text](https://github.com/golang/text) from 0.3.7 to 0.4.0. - [Release notes](https://github.com/golang/text/releases) - [Commits](golang/text@v0.3.7...v0.4.0) --- updated-dependencies: - dependency-name: golang.org/x/text dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> * :seeding: update CLI deps * golangci-lint: add recommended revive checks to linter-settings but disable checks with to many findings. Fix findings * Improve rendering of the documentation This fixes various rendering issues: * Wrong or uninterpreted formatting * Some missing links * Incorrect markup * Missing documentation pages This doesn't fix all the links but at least the initial ones. * update cronjob to use batchv1 api * Fix grammar in comment Change `these is` to `these are` * Enable revive unused-parameter check and fix findings * Bump github.com/onsi/ginkgo/v2 from 2.3.1 to 2.4.0 Bumps [github.com/onsi/ginkgo/v2](https://github.com/onsi/ginkgo) from 2.3.1 to 2.4.0. - [Release notes](https://github.com/onsi/ginkgo/releases) - [Changelog](https://github.com/onsi/ginkgo/blob/master/CHANGELOG.md) - [Commits](onsi/ginkgo@v2.3.1...v2.4.0) --- updated-dependencies: - dependency-name: github.com/onsi/ginkgo/v2 dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> * Bump github.com/spf13/cobra from 1.6.0 to 1.6.1 Bumps [github.com/spf13/cobra](https://github.com/spf13/cobra) from 1.6.0 to 1.6.1. - [Release notes](https://github.com/spf13/cobra/releases) - [Commits](spf13/cobra@v1.6.0...v1.6.1) --- updated-dependencies: - dependency-name: github.com/spf13/cobra dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> * Update github workflow to use same golangci-lint minor version as Makefile * fix docker buildx args Signed-off-by: Mikhail Sidorov <mixity@yandex.ru> * 🐛 (kustomize/v2-alpha): Fix typo issue in the labels added to the manifests (#3047) * Fix typo in kubernets (missing 'e') * make generate * Add KB project git-repo and edit icons * Add doc FAQ section * docs: supplement plugin creation * Update joelanford/go-apidiff (v0.4.0 -> v0.5.0) * Bump github.com/onsi/gomega from 1.22.1 to 1.23.0 Bumps [github.com/onsi/gomega](https://github.com/onsi/gomega) from 1.22.1 to 1.23.0. - [Release notes](https://github.com/onsi/gomega/releases) - [Changelog](https://github.com/onsi/gomega/blob/master/CHANGELOG.md) - [Commits](onsi/gomega@v1.22.1...v1.23.0) --- updated-dependencies: - dependency-name: github.com/onsi/gomega dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> * Bump github.com/onsi/gomega from 1.23.0 to 1.24.0 Bumps [github.com/onsi/gomega](https://github.com/onsi/gomega) from 1.23.0 to 1.24.0. - [Release notes](https://github.com/onsi/gomega/releases) - [Changelog](https://github.com/onsi/gomega/blob/master/CHANGELOG.md) - [Commits](onsi/gomega@v1.23.0...v1.24.0) --- updated-dependencies: - dependency-name: github.com/onsi/gomega dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> * Bump github.com/onsi/ginkgo/v2 from 2.4.0 to 2.5.0 Bumps [github.com/onsi/ginkgo/v2](https://github.com/onsi/ginkgo) from 2.4.0 to 2.5.0. - [Release notes](https://github.com/onsi/ginkgo/releases) - [Changelog](https://github.com/onsi/ginkgo/blob/master/CHANGELOG.md) - [Commits](onsi/ginkgo@v2.4.0...v2.5.0) --- updated-dependencies: - dependency-name: github.com/onsi/ginkgo/v2 dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> * Bump github.com/spf13/afero from 1.9.2 to 1.9.3 Bumps [github.com/spf13/afero](https://github.com/spf13/afero) from 1.9.2 to 1.9.3. - [Release notes](https://github.com/spf13/afero/releases) - [Commits](spf13/afero@v1.9.2...v1.9.3) --- updated-dependencies: - dependency-name: github.com/spf13/afero dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> * Bump golang.org/x/tools from 0.2.0 to 0.3.0 Bumps [golang.org/x/tools](https://github.com/golang/tools) from 0.2.0 to 0.3.0. - [Release notes](https://github.com/golang/tools/releases) - [Commits](golang/tools@v0.2.0...v0.3.0) --- updated-dependencies: - dependency-name: golang.org/x/tools dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> * Bump github.com/onsi/gomega from 1.24.0 to 1.24.1 Bumps [github.com/onsi/gomega](https://github.com/onsi/gomega) from 1.24.0 to 1.24.1. - [Release notes](https://github.com/onsi/gomega/releases) - [Changelog](https://github.com/onsi/gomega/blob/master/CHANGELOG.md) - [Commits](onsi/gomega@v1.24.0...v1.24.1) --- updated-dependencies: - dependency-name: github.com/onsi/gomega dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> * fix typo in Makefile * ✨ add version check for makefile template tools (#3077) * add version check for makefile template tools Prevent running controller-gen and kustomize commands with a version that does not match the one specified in the corresponding CONTROLLER_TOOLS_VERSION or KUSTOMIZE_VERSION vars Addresses #3068 * Update makefile target descriptions * Updated descriptions for `kustomize` and `controller-gen` targets. * Reformatted `controller-gen` recipe to reduce line length Signed-off-by: Eduardo Coria <emcoria@us.ibm.com> * update makefile samples Signed-off-by: Eduardo Coria <emcoria@us.ibm.com> Signed-off-by: Eduardo Coria <emcoria@us.ibm.com> * fix unexpected end of file error in makefiles Signed-off-by: Eduardo Coria <emcoria@us.ibm.com> * ✨ Add go/v4 base and migration guide Co-authored-by: Varsha <varshaprasad96@gmail.com> * Update docs/book/src/plugins/go-v4-plugin.md Co-authored-by: Varsha <varshaprasad96@gmail.com> * Update docs/book/src/migration/legacy.md Co-authored-by: Varsha <varshaprasad96@gmail.com> * Update docs/book/src/migration/manually_migration_guide_gov3_to_gov4.md Co-authored-by: Varsha <varshaprasad96@gmail.com> * Update docs/book/src/migration/manually_migration_guide_gov3_to_gov4.md Co-authored-by: Varsha <varshaprasad96@gmail.com> * Update docs/book/src/migration/manually_migration_guide_gov3_to_gov4.md Co-authored-by: Varsha <varshaprasad96@gmail.com> * (go/v3,go/v4-alpha): Upgrade controller-runtime version from 1.13.0 to 1.13.1 * 📖 : suggest specify plugin for pr * Bump github.com/onsi/ginkgo/v2 from 2.5.0 to 2.5.1 Bumps [github.com/onsi/ginkgo/v2](https://github.com/onsi/ginkgo) from 2.5.0 to 2.5.1. - [Release notes](https://github.com/onsi/ginkgo/releases) - [Changelog](https://github.com/onsi/ginkgo/blob/master/CHANGELOG.md) - [Commits](onsi/ginkgo@v2.5.0...v2.5.1) --- updated-dependencies: - dependency-name: github.com/onsi/ginkgo/v2 dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> * docs: fix typo in the component config tutorial Signed-off-by: Andreas Gerstmayr <agerstmayr@redhat.com> * 🌱: refact testdata * ✨ (kustomize/v2-alpha): add kustomize file to track crd sample info * add action to lint yaml and fix existing yamllint failures Signed-off-by: Bryce Palmer <bpalmer@redhat.com> * update yamllint to now be run via Makefile Signed-off-by: Bryce Palmer <bpalmer@redhat.com> * run yamllint target as part of lint target Signed-off-by: Bryce Palmer <bpalmer@redhat.com> * add yamllint job back as the lint job only runs golangci-lint Signed-off-by: Bryce Palmer <bpalmer@redhat.com> * bump proxy image * fix: Remove trailing space making yamllint fail on new project * (kustomize/v2-alpha): change kustomization file to track samples to use marker instead of overwritting * (deployimage/v1-alpha): fix error to scaffold go/v4-alpha projects * Replace restricted-access ComponentConfig design doc link with the public one Signed-off-by: Michail Resvanis <mresvani@redhat.com> Signed-off-by: Bryce Palmer <bpalmer@redhat.com> Signed-off-by: dependabot[bot] <support@github.com> Signed-off-by: Jirka Kremser <jiri.kremser@gmail.com> Signed-off-by: jesus m. rodriguez <jesusr@redhat.com> Signed-off-by: Mikhail Sidorov <mixity@yandex.ru> Signed-off-by: Eduardo Coria <emcoria@us.ibm.com> Signed-off-by: Andreas Gerstmayr <agerstmayr@redhat.com> Signed-off-by: Michail Resvanis <mresvani@redhat.com> Co-authored-by: Simon Jürgensmeyer <6493966+sj14@users.noreply.github.com> Co-authored-by: Kubernetes Prow Robot <k8s-ci-robot@users.noreply.github.com> Co-authored-by: Camila Macedo <cmacedo@redhat.com> Co-authored-by: Bryce Palmer <bpalmer@redhat.com> Co-authored-by: Tony <kavinjsir@gmail.com> Co-authored-by: Oscar Utbult <oscar.utbult@gmail.com> Co-authored-by: Yash Singh <syash@vmware.com> Co-authored-by: Abhishek koserwal <akoserwa@redhat.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Jirka Kremser <535866+jkremser@users.noreply.github.com> Co-authored-by: laxmikantbpandhare <laxmikantpandhare@gmail.com> Co-authored-by: jesus m. rodriguez <jesusr@redhat.com> Co-authored-by: Phillip Wittrock <Phil.Wittrock@gmail.com> Co-authored-by: Yash Singh <99066083+yashsingh74@users.noreply.github.com> Co-authored-by: Laxmikant Bhaskar Pandhare <47066536+laxmikantbpandhare@users.noreply.github.com> Co-authored-by: astraw99 <wangchengiscool@gmail.com> Co-authored-by: Jonathan Ballet <jon@multani.info> Co-authored-by: Krishna Indani <indanikrishna@gmail.com> Co-authored-by: Nicholas Seemiller <seemiller@gmail.com> Co-authored-by: Mikhail Sidorov <mixity@yandex.ru> Co-authored-by: Marc Villacorta <h0tbird@github.com> Co-authored-by: Shunsuke Ise <ise@ebiiim.com> Co-authored-by: Eduardo M Coria <coriaedu@gmail.com> Co-authored-by: Eduardo Coria <emcoria@us.ibm.com> Co-authored-by: Varsha <varshaprasad96@gmail.com> Co-authored-by: Andreas Gerstmayr <agerstmayr@redhat.com> Co-authored-by: Erik Godding Boye <egboye@gmail.com> Co-authored-by: Michail Resvanis <mresvani@redhat.com>
camilamacedo86
added a commit
to camilamacedo86/kubebuilder
that referenced
this pull request
Jan 16, 2023
* Fix nil pointer in Finalizer example * 📖 fix link for platform support * update kubebuilder core dependencies for k8s 1.25 Signed-off-by: Bryce Palmer <bpalmer@redhat.com> * docs: notify deps install to build book * Update controller-tools version (v0.9.2->v0.10.0) * 🐛 remove duplicate words and fix spelling mistakes * ✨ update kubebuilder kubernetes version * Update the export path of webhook * 📖 fix broken links * fixing the kubebuilder install locally curl request * add dependency bot updates * 🌱 Bump actions/checkout from 2 to 3 Bumps [actions/checkout](https://github.com/actions/checkout) from 2 to 3. - [Release notes](https://github.com/actions/checkout/releases) - [Changelog](https://github.com/actions/checkout/blob/main/CHANGELOG.md) - [Commits](actions/checkout@v2...v3) --- updated-dependencies: - dependency-name: actions/checkout dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com> * 🌱 Bump actions/setup-go from 2 to 3 Bumps [actions/setup-go](https://github.com/actions/setup-go) from 2 to 3. - [Release notes](https://github.com/actions/setup-go/releases) - [Commits](actions/setup-go@v2...v3) --- updated-dependencies: - dependency-name: actions/setup-go dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com> * 🌱 Bump goreleaser/goreleaser-action from 2 to 3 Bumps [goreleaser/goreleaser-action](https://github.com/goreleaser/goreleaser-action) from 2 to 3. - [Release notes](https://github.com/goreleaser/goreleaser-action/releases) - [Commits](goreleaser/goreleaser-action@v2...v3) --- updated-dependencies: - dependency-name: goreleaser/goreleaser-action dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com> * Bump github.com/spf13/afero from 1.6.0 to 1.9.2 Bumps [github.com/spf13/afero](https://github.com/spf13/afero) from 1.6.0 to 1.9.2. - [Release notes](https://github.com/spf13/afero/releases) - [Commits](spf13/afero@v1.6.0...v1.9.2) --- updated-dependencies: - dependency-name: github.com/spf13/afero dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> * Bump github.com/onsi/gomega from 1.19.0 to 1.20.2 Bumps [github.com/onsi/gomega](https://github.com/onsi/gomega) from 1.19.0 to 1.20.2. - [Release notes](https://github.com/onsi/gomega/releases) - [Changelog](https://github.com/onsi/gomega/blob/master/CHANGELOG.md) - [Commits](onsi/gomega@v1.19.0...v1.20.2) --- updated-dependencies: - dependency-name: github.com/onsi/gomega dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> * Bump github.com/sirupsen/logrus from 1.8.1 to 1.9.0 Bumps [github.com/sirupsen/logrus](https://github.com/sirupsen/logrus) from 1.8.1 to 1.9.0. - [Release notes](https://github.com/sirupsen/logrus/releases) - [Changelog](https://github.com/sirupsen/logrus/blob/master/CHANGELOG.md) - [Commits](sirupsen/logrus@v1.8.1...v1.9.0) --- updated-dependencies: - dependency-name: github.com/sirupsen/logrus dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> * Bump k8s.io/apimachinery from 0.25.0 to 0.25.2 Bumps [k8s.io/apimachinery](https://github.com/kubernetes/apimachinery) from 0.25.0 to 0.25.2. - [Release notes](https://github.com/kubernetes/apimachinery/releases) - [Commits](kubernetes/apimachinery@v0.25.0...v0.25.2) --- updated-dependencies: - dependency-name: k8s.io/apimachinery dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> * Bump github.com/gobuffalo/flect from 0.2.5 to 0.3.0 Bumps [github.com/gobuffalo/flect](https://github.com/gobuffalo/flect) from 0.2.5 to 0.3.0. - [Release notes](https://github.com/gobuffalo/flect/releases) - [Commits](gobuffalo/flect@v0.2.5...v0.3.0) --- updated-dependencies: - dependency-name: github.com/gobuffalo/flect dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> * docs: describe e2e test towards plugin Co-authored-by: Camila Macedo <7708031+camilamacedo86@users.noreply.github.com> * 🌱 remove WORKSPACE file commited by mistake * remove unused value * Bump github.com/spf13/cobra from 1.4.0 to 1.5.0 Bumps [github.com/spf13/cobra](https://github.com/spf13/cobra) from 1.4.0 to 1.5.0. - [Release notes](https://github.com/spf13/cobra/releases) - [Commits](spf13/cobra@v1.4.0...v1.5.0) --- updated-dependencies: - dependency-name: github.com/spf13/cobra dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> * Bump github.com/onsi/ginkgo/v2 from 2.1.6 to 2.2.0 Bumps [github.com/onsi/ginkgo/v2](https://github.com/onsi/ginkgo) from 2.1.6 to 2.2.0. - [Release notes](https://github.com/onsi/ginkgo/releases) - [Changelog](https://github.com/onsi/ginkgo/blob/master/CHANGELOG.md) - [Commits](onsi/ginkgo@v2.1.6...v2.2.0) --- updated-dependencies: - dependency-name: github.com/onsi/ginkgo/v2 dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> * Bump github.com/cloudflare/cfssl from 1.5.0 to 1.6.3 Bumps [github.com/cloudflare/cfssl](https://github.com/cloudflare/cfssl) from 1.5.0 to 1.6.3. - [Release notes](https://github.com/cloudflare/cfssl/releases) - [Changelog](https://github.com/cloudflare/cfssl/blob/master/CHANGELOG) - [Commits](cloudflare/cfssl@v1.5.0...v1.6.3) --- updated-dependencies: - dependency-name: github.com/cloudflare/cfssl dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> * update simple-external-plugin-tutorial * update mdbook *⚠️ remove config-gen alpha option * 📖 clarifies plugins available and its usage * 📖 update doc samples * ✨ (go/v4-alpha) : update kustomize version from 4.5.5 to 4.5.7 * ✨ (grafana/v1-alpha) : add custom units for custom grafana dashboards (kubernetes-sigs#2965) :sparkles: add custom units for custom grafana dashboards Signed-off-by: Jirka Kremser <jiri.kremser@gmail.com> Signed-off-by: Jirka Kremser <jiri.kremser@gmail.com> * cleanup: cert-manager and prometheus installs into e2e tests * Apply suggestions from code review * fixed bug for component-config flag updated testdata * Make jmrodri and varsha admins Signed-off-by: jesus m. rodriguez <jesusr@redhat.com> * Bump github.com/onsi/gomega from 1.20.2 to 1.21.1 Bumps [github.com/onsi/gomega](https://github.com/onsi/gomega) from 1.20.2 to 1.21.1. - [Release notes](https://github.com/onsi/gomega/releases) - [Changelog](https://github.com/onsi/gomega/blob/master/CHANGELOG.md) - [Commits](onsi/gomega@v1.20.2...v1.21.1) --- updated-dependencies: - dependency-name: github.com/onsi/gomega dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> * 📖 Updating doc with Installation steps of cert-manager and prometheus (kubernetes-sigs#2982) * Adding installing steps for testing webhooks Adding installing steps for testing webhooks Adding installing steps for testing webhooks Adding installing steps for testing webhooks Adding installing steps for testing webhooks Adding installing steps for testing webhooks Adding installing steps for testing webhooks Adding installing steps for testing webhooks Adding installing steps for testing webhooks Adding installing steps for testing webhooks Adding installing steps for testing webhooks Adding installing steps for testing webhooks * Adding installing steps for testing webhooks * Adding installing steps for testing webhooks * Adding installing steps for testing webhooks * 🐛 : leader-elect arg scaffolded should be scaffolded when component config option is not used (kubernetes-sigs#3013) * updated templates for component config * updates * update * update revert main.go * update revert main.go * revert changes and go thru docs once * Update make build cmd with manifests * Bump github.com/spf13/cobra from 1.5.0 to 1.6.0 Bumps [github.com/spf13/cobra](https://github.com/spf13/cobra) from 1.5.0 to 1.6.0. - [Release notes](https://github.com/spf13/cobra/releases) - [Commits](spf13/cobra@v1.5.0...v1.6.0) --- updated-dependencies: - dependency-name: github.com/spf13/cobra dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> * Bump golang.org/x/text from 0.3.7 to 0.4.0 Bumps [golang.org/x/text](https://github.com/golang/text) from 0.3.7 to 0.4.0. - [Release notes](https://github.com/golang/text/releases) - [Commits](golang/text@v0.3.7...v0.4.0) --- updated-dependencies: - dependency-name: golang.org/x/text dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> * :seeding: update CLI deps * golangci-lint: add recommended revive checks to linter-settings but disable checks with to many findings. Fix findings * Improve rendering of the documentation This fixes various rendering issues: * Wrong or uninterpreted formatting * Some missing links * Incorrect markup * Missing documentation pages This doesn't fix all the links but at least the initial ones. * update cronjob to use batchv1 api * Fix grammar in comment Change `these is` to `these are` * Enable revive unused-parameter check and fix findings * Bump github.com/onsi/ginkgo/v2 from 2.3.1 to 2.4.0 Bumps [github.com/onsi/ginkgo/v2](https://github.com/onsi/ginkgo) from 2.3.1 to 2.4.0. - [Release notes](https://github.com/onsi/ginkgo/releases) - [Changelog](https://github.com/onsi/ginkgo/blob/master/CHANGELOG.md) - [Commits](onsi/ginkgo@v2.3.1...v2.4.0) --- updated-dependencies: - dependency-name: github.com/onsi/ginkgo/v2 dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> * Bump github.com/spf13/cobra from 1.6.0 to 1.6.1 Bumps [github.com/spf13/cobra](https://github.com/spf13/cobra) from 1.6.0 to 1.6.1. - [Release notes](https://github.com/spf13/cobra/releases) - [Commits](spf13/cobra@v1.6.0...v1.6.1) --- updated-dependencies: - dependency-name: github.com/spf13/cobra dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> * Update github workflow to use same golangci-lint minor version as Makefile * fix docker buildx args Signed-off-by: Mikhail Sidorov <mixity@yandex.ru> * 🐛 (kustomize/v2-alpha): Fix typo issue in the labels added to the manifests (kubernetes-sigs#3047) * Fix typo in kubernets (missing 'e') * make generate * Add KB project git-repo and edit icons * Add doc FAQ section * docs: supplement plugin creation * Update joelanford/go-apidiff (v0.4.0 -> v0.5.0) * Bump github.com/onsi/gomega from 1.22.1 to 1.23.0 Bumps [github.com/onsi/gomega](https://github.com/onsi/gomega) from 1.22.1 to 1.23.0. - [Release notes](https://github.com/onsi/gomega/releases) - [Changelog](https://github.com/onsi/gomega/blob/master/CHANGELOG.md) - [Commits](onsi/gomega@v1.22.1...v1.23.0) --- updated-dependencies: - dependency-name: github.com/onsi/gomega dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> * Bump github.com/onsi/gomega from 1.23.0 to 1.24.0 Bumps [github.com/onsi/gomega](https://github.com/onsi/gomega) from 1.23.0 to 1.24.0. - [Release notes](https://github.com/onsi/gomega/releases) - [Changelog](https://github.com/onsi/gomega/blob/master/CHANGELOG.md) - [Commits](onsi/gomega@v1.23.0...v1.24.0) --- updated-dependencies: - dependency-name: github.com/onsi/gomega dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> * Bump github.com/onsi/ginkgo/v2 from 2.4.0 to 2.5.0 Bumps [github.com/onsi/ginkgo/v2](https://github.com/onsi/ginkgo) from 2.4.0 to 2.5.0. - [Release notes](https://github.com/onsi/ginkgo/releases) - [Changelog](https://github.com/onsi/ginkgo/blob/master/CHANGELOG.md) - [Commits](onsi/ginkgo@v2.4.0...v2.5.0) --- updated-dependencies: - dependency-name: github.com/onsi/ginkgo/v2 dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> * Bump github.com/spf13/afero from 1.9.2 to 1.9.3 Bumps [github.com/spf13/afero](https://github.com/spf13/afero) from 1.9.2 to 1.9.3. - [Release notes](https://github.com/spf13/afero/releases) - [Commits](spf13/afero@v1.9.2...v1.9.3) --- updated-dependencies: - dependency-name: github.com/spf13/afero dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> * Bump golang.org/x/tools from 0.2.0 to 0.3.0 Bumps [golang.org/x/tools](https://github.com/golang/tools) from 0.2.0 to 0.3.0. - [Release notes](https://github.com/golang/tools/releases) - [Commits](golang/tools@v0.2.0...v0.3.0) --- updated-dependencies: - dependency-name: golang.org/x/tools dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> * Bump github.com/onsi/gomega from 1.24.0 to 1.24.1 Bumps [github.com/onsi/gomega](https://github.com/onsi/gomega) from 1.24.0 to 1.24.1. - [Release notes](https://github.com/onsi/gomega/releases) - [Changelog](https://github.com/onsi/gomega/blob/master/CHANGELOG.md) - [Commits](onsi/gomega@v1.24.0...v1.24.1) --- updated-dependencies: - dependency-name: github.com/onsi/gomega dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> * fix typo in Makefile * ✨ add version check for makefile template tools (kubernetes-sigs#3077) * add version check for makefile template tools Prevent running controller-gen and kustomize commands with a version that does not match the one specified in the corresponding CONTROLLER_TOOLS_VERSION or KUSTOMIZE_VERSION vars Addresses kubernetes-sigs#3068 * Update makefile target descriptions * Updated descriptions for `kustomize` and `controller-gen` targets. * Reformatted `controller-gen` recipe to reduce line length Signed-off-by: Eduardo Coria <emcoria@us.ibm.com> * update makefile samples Signed-off-by: Eduardo Coria <emcoria@us.ibm.com> Signed-off-by: Eduardo Coria <emcoria@us.ibm.com> * fix unexpected end of file error in makefiles Signed-off-by: Eduardo Coria <emcoria@us.ibm.com> * ✨ Add go/v4 base and migration guide Co-authored-by: Varsha <varshaprasad96@gmail.com> * Update docs/book/src/plugins/go-v4-plugin.md Co-authored-by: Varsha <varshaprasad96@gmail.com> * Update docs/book/src/migration/legacy.md Co-authored-by: Varsha <varshaprasad96@gmail.com> * Update docs/book/src/migration/manually_migration_guide_gov3_to_gov4.md Co-authored-by: Varsha <varshaprasad96@gmail.com> * Update docs/book/src/migration/manually_migration_guide_gov3_to_gov4.md Co-authored-by: Varsha <varshaprasad96@gmail.com> * Update docs/book/src/migration/manually_migration_guide_gov3_to_gov4.md Co-authored-by: Varsha <varshaprasad96@gmail.com> * (go/v3,go/v4-alpha): Upgrade controller-runtime version from 1.13.0 to 1.13.1 * 📖 : suggest specify plugin for pr * Bump github.com/onsi/ginkgo/v2 from 2.5.0 to 2.5.1 Bumps [github.com/onsi/ginkgo/v2](https://github.com/onsi/ginkgo) from 2.5.0 to 2.5.1. - [Release notes](https://github.com/onsi/ginkgo/releases) - [Changelog](https://github.com/onsi/ginkgo/blob/master/CHANGELOG.md) - [Commits](onsi/ginkgo@v2.5.0...v2.5.1) --- updated-dependencies: - dependency-name: github.com/onsi/ginkgo/v2 dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> * docs: fix typo in the component config tutorial Signed-off-by: Andreas Gerstmayr <agerstmayr@redhat.com> * 🌱: refact testdata * ✨ (kustomize/v2-alpha): add kustomize file to track crd sample info * add action to lint yaml and fix existing yamllint failures Signed-off-by: Bryce Palmer <bpalmer@redhat.com> * update yamllint to now be run via Makefile Signed-off-by: Bryce Palmer <bpalmer@redhat.com> * run yamllint target as part of lint target Signed-off-by: Bryce Palmer <bpalmer@redhat.com> * add yamllint job back as the lint job only runs golangci-lint Signed-off-by: Bryce Palmer <bpalmer@redhat.com> * bump proxy image * fix: Remove trailing space making yamllint fail on new project * (kustomize/v2-alpha): change kustomization file to track samples to use marker instead of overwritting * (deployimage/v1-alpha): fix error to scaffold go/v4-alpha projects * Replace restricted-access ComponentConfig design doc link with the public one Signed-off-by: Michail Resvanis <mresvani@redhat.com> Signed-off-by: Bryce Palmer <bpalmer@redhat.com> Signed-off-by: dependabot[bot] <support@github.com> Signed-off-by: Jirka Kremser <jiri.kremser@gmail.com> Signed-off-by: jesus m. rodriguez <jesusr@redhat.com> Signed-off-by: Mikhail Sidorov <mixity@yandex.ru> Signed-off-by: Eduardo Coria <emcoria@us.ibm.com> Signed-off-by: Andreas Gerstmayr <agerstmayr@redhat.com> Signed-off-by: Michail Resvanis <mresvani@redhat.com> Co-authored-by: Simon Jürgensmeyer <6493966+sj14@users.noreply.github.com> Co-authored-by: Kubernetes Prow Robot <k8s-ci-robot@users.noreply.github.com> Co-authored-by: Camila Macedo <cmacedo@redhat.com> Co-authored-by: Bryce Palmer <bpalmer@redhat.com> Co-authored-by: Tony <kavinjsir@gmail.com> Co-authored-by: Oscar Utbult <oscar.utbult@gmail.com> Co-authored-by: Yash Singh <syash@vmware.com> Co-authored-by: Abhishek koserwal <akoserwa@redhat.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Jirka Kremser <535866+jkremser@users.noreply.github.com> Co-authored-by: laxmikantbpandhare <laxmikantpandhare@gmail.com> Co-authored-by: jesus m. rodriguez <jesusr@redhat.com> Co-authored-by: Phillip Wittrock <Phil.Wittrock@gmail.com> Co-authored-by: Yash Singh <99066083+yashsingh74@users.noreply.github.com> Co-authored-by: Laxmikant Bhaskar Pandhare <47066536+laxmikantbpandhare@users.noreply.github.com> Co-authored-by: astraw99 <wangchengiscool@gmail.com> Co-authored-by: Jonathan Ballet <jon@multani.info> Co-authored-by: Krishna Indani <indanikrishna@gmail.com> Co-authored-by: Nicholas Seemiller <seemiller@gmail.com> Co-authored-by: Mikhail Sidorov <mixity@yandex.ru> Co-authored-by: Marc Villacorta <h0tbird@github.com> Co-authored-by: Shunsuke Ise <ise@ebiiim.com> Co-authored-by: Eduardo M Coria <coriaedu@gmail.com> Co-authored-by: Eduardo Coria <emcoria@us.ibm.com> Co-authored-by: Varsha <varshaprasad96@gmail.com> Co-authored-by: Andreas Gerstmayr <agerstmayr@redhat.com> Co-authored-by: Erik Godding Boye <egboye@gmail.com> Co-authored-by: Michail Resvanis <mresvani@redhat.com>
camilamacedo86
added a commit
that referenced
this pull request
Jan 16, 2023
* Fix nil pointer in Finalizer example * 📖 fix link for platform support * update kubebuilder core dependencies for k8s 1.25 Signed-off-by: Bryce Palmer <bpalmer@redhat.com> * docs: notify deps install to build book * Update controller-tools version (v0.9.2->v0.10.0) * 🐛 remove duplicate words and fix spelling mistakes * ✨ update kubebuilder kubernetes version * Update the export path of webhook * 📖 fix broken links * fixing the kubebuilder install locally curl request * add dependency bot updates * 🌱 Bump actions/checkout from 2 to 3 Bumps [actions/checkout](https://github.com/actions/checkout) from 2 to 3. - [Release notes](https://github.com/actions/checkout/releases) - [Changelog](https://github.com/actions/checkout/blob/main/CHANGELOG.md) - [Commits](actions/checkout@v2...v3) --- updated-dependencies: - dependency-name: actions/checkout dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com> * 🌱 Bump actions/setup-go from 2 to 3 Bumps [actions/setup-go](https://github.com/actions/setup-go) from 2 to 3. - [Release notes](https://github.com/actions/setup-go/releases) - [Commits](actions/setup-go@v2...v3) --- updated-dependencies: - dependency-name: actions/setup-go dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com> * 🌱 Bump goreleaser/goreleaser-action from 2 to 3 Bumps [goreleaser/goreleaser-action](https://github.com/goreleaser/goreleaser-action) from 2 to 3. - [Release notes](https://github.com/goreleaser/goreleaser-action/releases) - [Commits](goreleaser/goreleaser-action@v2...v3) --- updated-dependencies: - dependency-name: goreleaser/goreleaser-action dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com> * Bump github.com/spf13/afero from 1.6.0 to 1.9.2 Bumps [github.com/spf13/afero](https://github.com/spf13/afero) from 1.6.0 to 1.9.2. - [Release notes](https://github.com/spf13/afero/releases) - [Commits](spf13/afero@v1.6.0...v1.9.2) --- updated-dependencies: - dependency-name: github.com/spf13/afero dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> * Bump github.com/onsi/gomega from 1.19.0 to 1.20.2 Bumps [github.com/onsi/gomega](https://github.com/onsi/gomega) from 1.19.0 to 1.20.2. - [Release notes](https://github.com/onsi/gomega/releases) - [Changelog](https://github.com/onsi/gomega/blob/master/CHANGELOG.md) - [Commits](onsi/gomega@v1.19.0...v1.20.2) --- updated-dependencies: - dependency-name: github.com/onsi/gomega dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> * Bump github.com/sirupsen/logrus from 1.8.1 to 1.9.0 Bumps [github.com/sirupsen/logrus](https://github.com/sirupsen/logrus) from 1.8.1 to 1.9.0. - [Release notes](https://github.com/sirupsen/logrus/releases) - [Changelog](https://github.com/sirupsen/logrus/blob/master/CHANGELOG.md) - [Commits](sirupsen/logrus@v1.8.1...v1.9.0) --- updated-dependencies: - dependency-name: github.com/sirupsen/logrus dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> * Bump k8s.io/apimachinery from 0.25.0 to 0.25.2 Bumps [k8s.io/apimachinery](https://github.com/kubernetes/apimachinery) from 0.25.0 to 0.25.2. - [Release notes](https://github.com/kubernetes/apimachinery/releases) - [Commits](kubernetes/apimachinery@v0.25.0...v0.25.2) --- updated-dependencies: - dependency-name: k8s.io/apimachinery dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> * Bump github.com/gobuffalo/flect from 0.2.5 to 0.3.0 Bumps [github.com/gobuffalo/flect](https://github.com/gobuffalo/flect) from 0.2.5 to 0.3.0. - [Release notes](https://github.com/gobuffalo/flect/releases) - [Commits](gobuffalo/flect@v0.2.5...v0.3.0) --- updated-dependencies: - dependency-name: github.com/gobuffalo/flect dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> * docs: describe e2e test towards plugin Co-authored-by: Camila Macedo <7708031+camilamacedo86@users.noreply.github.com> * 🌱 remove WORKSPACE file commited by mistake * remove unused value * Bump github.com/spf13/cobra from 1.4.0 to 1.5.0 Bumps [github.com/spf13/cobra](https://github.com/spf13/cobra) from 1.4.0 to 1.5.0. - [Release notes](https://github.com/spf13/cobra/releases) - [Commits](spf13/cobra@v1.4.0...v1.5.0) --- updated-dependencies: - dependency-name: github.com/spf13/cobra dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> * Bump github.com/onsi/ginkgo/v2 from 2.1.6 to 2.2.0 Bumps [github.com/onsi/ginkgo/v2](https://github.com/onsi/ginkgo) from 2.1.6 to 2.2.0. - [Release notes](https://github.com/onsi/ginkgo/releases) - [Changelog](https://github.com/onsi/ginkgo/blob/master/CHANGELOG.md) - [Commits](onsi/ginkgo@v2.1.6...v2.2.0) --- updated-dependencies: - dependency-name: github.com/onsi/ginkgo/v2 dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> * Bump github.com/cloudflare/cfssl from 1.5.0 to 1.6.3 Bumps [github.com/cloudflare/cfssl](https://github.com/cloudflare/cfssl) from 1.5.0 to 1.6.3. - [Release notes](https://github.com/cloudflare/cfssl/releases) - [Changelog](https://github.com/cloudflare/cfssl/blob/master/CHANGELOG) - [Commits](cloudflare/cfssl@v1.5.0...v1.6.3) --- updated-dependencies: - dependency-name: github.com/cloudflare/cfssl dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> * update simple-external-plugin-tutorial * update mdbook *⚠️ remove config-gen alpha option * 📖 clarifies plugins available and its usage * 📖 update doc samples * ✨ (go/v4-alpha) : update kustomize version from 4.5.5 to 4.5.7 * ✨ (grafana/v1-alpha) : add custom units for custom grafana dashboards (#2965) :sparkles: add custom units for custom grafana dashboards Signed-off-by: Jirka Kremser <jiri.kremser@gmail.com> Signed-off-by: Jirka Kremser <jiri.kremser@gmail.com> * cleanup: cert-manager and prometheus installs into e2e tests * Apply suggestions from code review * fixed bug for component-config flag updated testdata * Make jmrodri and varsha admins Signed-off-by: jesus m. rodriguez <jesusr@redhat.com> * Bump github.com/onsi/gomega from 1.20.2 to 1.21.1 Bumps [github.com/onsi/gomega](https://github.com/onsi/gomega) from 1.20.2 to 1.21.1. - [Release notes](https://github.com/onsi/gomega/releases) - [Changelog](https://github.com/onsi/gomega/blob/master/CHANGELOG.md) - [Commits](onsi/gomega@v1.20.2...v1.21.1) --- updated-dependencies: - dependency-name: github.com/onsi/gomega dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> * 📖 Updating doc with Installation steps of cert-manager and prometheus (#2982) * Adding installing steps for testing webhooks Adding installing steps for testing webhooks Adding installing steps for testing webhooks Adding installing steps for testing webhooks Adding installing steps for testing webhooks Adding installing steps for testing webhooks Adding installing steps for testing webhooks Adding installing steps for testing webhooks Adding installing steps for testing webhooks Adding installing steps for testing webhooks Adding installing steps for testing webhooks Adding installing steps for testing webhooks * Adding installing steps for testing webhooks * Adding installing steps for testing webhooks * Adding installing steps for testing webhooks * 🐛 : leader-elect arg scaffolded should be scaffolded when component config option is not used (#3013) * updated templates for component config * updates * update * update revert main.go * update revert main.go * revert changes and go thru docs once * Update make build cmd with manifests * Bump github.com/spf13/cobra from 1.5.0 to 1.6.0 Bumps [github.com/spf13/cobra](https://github.com/spf13/cobra) from 1.5.0 to 1.6.0. - [Release notes](https://github.com/spf13/cobra/releases) - [Commits](spf13/cobra@v1.5.0...v1.6.0) --- updated-dependencies: - dependency-name: github.com/spf13/cobra dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> * Bump golang.org/x/text from 0.3.7 to 0.4.0 Bumps [golang.org/x/text](https://github.com/golang/text) from 0.3.7 to 0.4.0. - [Release notes](https://github.com/golang/text/releases) - [Commits](golang/text@v0.3.7...v0.4.0) --- updated-dependencies: - dependency-name: golang.org/x/text dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> * :seeding: update CLI deps * golangci-lint: add recommended revive checks to linter-settings but disable checks with to many findings. Fix findings * Improve rendering of the documentation This fixes various rendering issues: * Wrong or uninterpreted formatting * Some missing links * Incorrect markup * Missing documentation pages This doesn't fix all the links but at least the initial ones. * update cronjob to use batchv1 api * Fix grammar in comment Change `these is` to `these are` * Enable revive unused-parameter check and fix findings * Bump github.com/onsi/ginkgo/v2 from 2.3.1 to 2.4.0 Bumps [github.com/onsi/ginkgo/v2](https://github.com/onsi/ginkgo) from 2.3.1 to 2.4.0. - [Release notes](https://github.com/onsi/ginkgo/releases) - [Changelog](https://github.com/onsi/ginkgo/blob/master/CHANGELOG.md) - [Commits](onsi/ginkgo@v2.3.1...v2.4.0) --- updated-dependencies: - dependency-name: github.com/onsi/ginkgo/v2 dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> * Bump github.com/spf13/cobra from 1.6.0 to 1.6.1 Bumps [github.com/spf13/cobra](https://github.com/spf13/cobra) from 1.6.0 to 1.6.1. - [Release notes](https://github.com/spf13/cobra/releases) - [Commits](spf13/cobra@v1.6.0...v1.6.1) --- updated-dependencies: - dependency-name: github.com/spf13/cobra dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> * Update github workflow to use same golangci-lint minor version as Makefile * fix docker buildx args Signed-off-by: Mikhail Sidorov <mixity@yandex.ru> * 🐛 (kustomize/v2-alpha): Fix typo issue in the labels added to the manifests (#3047) * Fix typo in kubernets (missing 'e') * make generate * Add KB project git-repo and edit icons * Add doc FAQ section * docs: supplement plugin creation * Update joelanford/go-apidiff (v0.4.0 -> v0.5.0) * Bump github.com/onsi/gomega from 1.22.1 to 1.23.0 Bumps [github.com/onsi/gomega](https://github.com/onsi/gomega) from 1.22.1 to 1.23.0. - [Release notes](https://github.com/onsi/gomega/releases) - [Changelog](https://github.com/onsi/gomega/blob/master/CHANGELOG.md) - [Commits](onsi/gomega@v1.22.1...v1.23.0) --- updated-dependencies: - dependency-name: github.com/onsi/gomega dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> * Bump github.com/onsi/gomega from 1.23.0 to 1.24.0 Bumps [github.com/onsi/gomega](https://github.com/onsi/gomega) from 1.23.0 to 1.24.0. - [Release notes](https://github.com/onsi/gomega/releases) - [Changelog](https://github.com/onsi/gomega/blob/master/CHANGELOG.md) - [Commits](onsi/gomega@v1.23.0...v1.24.0) --- updated-dependencies: - dependency-name: github.com/onsi/gomega dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> * Bump github.com/onsi/ginkgo/v2 from 2.4.0 to 2.5.0 Bumps [github.com/onsi/ginkgo/v2](https://github.com/onsi/ginkgo) from 2.4.0 to 2.5.0. - [Release notes](https://github.com/onsi/ginkgo/releases) - [Changelog](https://github.com/onsi/ginkgo/blob/master/CHANGELOG.md) - [Commits](onsi/ginkgo@v2.4.0...v2.5.0) --- updated-dependencies: - dependency-name: github.com/onsi/ginkgo/v2 dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> * Bump github.com/spf13/afero from 1.9.2 to 1.9.3 Bumps [github.com/spf13/afero](https://github.com/spf13/afero) from 1.9.2 to 1.9.3. - [Release notes](https://github.com/spf13/afero/releases) - [Commits](spf13/afero@v1.9.2...v1.9.3) --- updated-dependencies: - dependency-name: github.com/spf13/afero dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> * Bump golang.org/x/tools from 0.2.0 to 0.3.0 Bumps [golang.org/x/tools](https://github.com/golang/tools) from 0.2.0 to 0.3.0. - [Release notes](https://github.com/golang/tools/releases) - [Commits](golang/tools@v0.2.0...v0.3.0) --- updated-dependencies: - dependency-name: golang.org/x/tools dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> * Bump github.com/onsi/gomega from 1.24.0 to 1.24.1 Bumps [github.com/onsi/gomega](https://github.com/onsi/gomega) from 1.24.0 to 1.24.1. - [Release notes](https://github.com/onsi/gomega/releases) - [Changelog](https://github.com/onsi/gomega/blob/master/CHANGELOG.md) - [Commits](onsi/gomega@v1.24.0...v1.24.1) --- updated-dependencies: - dependency-name: github.com/onsi/gomega dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> * fix typo in Makefile * ✨ add version check for makefile template tools (#3077) * add version check for makefile template tools Prevent running controller-gen and kustomize commands with a version that does not match the one specified in the corresponding CONTROLLER_TOOLS_VERSION or KUSTOMIZE_VERSION vars Addresses #3068 * Update makefile target descriptions * Updated descriptions for `kustomize` and `controller-gen` targets. * Reformatted `controller-gen` recipe to reduce line length Signed-off-by: Eduardo Coria <emcoria@us.ibm.com> * update makefile samples Signed-off-by: Eduardo Coria <emcoria@us.ibm.com> Signed-off-by: Eduardo Coria <emcoria@us.ibm.com> * fix unexpected end of file error in makefiles Signed-off-by: Eduardo Coria <emcoria@us.ibm.com> * ✨ Add go/v4 base and migration guide Co-authored-by: Varsha <varshaprasad96@gmail.com> * Update docs/book/src/plugins/go-v4-plugin.md Co-authored-by: Varsha <varshaprasad96@gmail.com> * Update docs/book/src/migration/legacy.md Co-authored-by: Varsha <varshaprasad96@gmail.com> * Update docs/book/src/migration/manually_migration_guide_gov3_to_gov4.md Co-authored-by: Varsha <varshaprasad96@gmail.com> * Update docs/book/src/migration/manually_migration_guide_gov3_to_gov4.md Co-authored-by: Varsha <varshaprasad96@gmail.com> * Update docs/book/src/migration/manually_migration_guide_gov3_to_gov4.md Co-authored-by: Varsha <varshaprasad96@gmail.com> * (go/v3,go/v4-alpha): Upgrade controller-runtime version from 1.13.0 to 1.13.1 * 📖 : suggest specify plugin for pr * Bump github.com/onsi/ginkgo/v2 from 2.5.0 to 2.5.1 Bumps [github.com/onsi/ginkgo/v2](https://github.com/onsi/ginkgo) from 2.5.0 to 2.5.1. - [Release notes](https://github.com/onsi/ginkgo/releases) - [Changelog](https://github.com/onsi/ginkgo/blob/master/CHANGELOG.md) - [Commits](onsi/ginkgo@v2.5.0...v2.5.1) --- updated-dependencies: - dependency-name: github.com/onsi/ginkgo/v2 dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> * docs: fix typo in the component config tutorial Signed-off-by: Andreas Gerstmayr <agerstmayr@redhat.com> * 🌱: refact testdata * ✨ (kustomize/v2-alpha): add kustomize file to track crd sample info * add action to lint yaml and fix existing yamllint failures Signed-off-by: Bryce Palmer <bpalmer@redhat.com> * update yamllint to now be run via Makefile Signed-off-by: Bryce Palmer <bpalmer@redhat.com> * run yamllint target as part of lint target Signed-off-by: Bryce Palmer <bpalmer@redhat.com> * add yamllint job back as the lint job only runs golangci-lint Signed-off-by: Bryce Palmer <bpalmer@redhat.com> * bump proxy image * fix: Remove trailing space making yamllint fail on new project * (kustomize/v2-alpha): change kustomization file to track samples to use marker instead of overwritting * (deployimage/v1-alpha): fix error to scaffold go/v4-alpha projects * Replace restricted-access ComponentConfig design doc link with the public one Signed-off-by: Michail Resvanis <mresvani@redhat.com> * Bump golang.org/x/text from 0.4.0 to 0.5.0 Bumps [golang.org/x/text](https://github.com/golang/text) from 0.4.0 to 0.5.0. - [Release notes](https://github.com/golang/text/releases) - [Commits](golang/text@v0.4.0...v0.5.0) --- updated-dependencies: - dependency-name: golang.org/x/text dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> * fix lint issue * 🌱 Change testdata suffix and regenerate samples (#3111) * edit script * make generate * fix test name * project-v3-with-grafana * book: add details rbac doc in tutorial Signed-off-by: qingwave <isguory@gmail.com> * improve golang/v3/v4 README template * correctly spell "until" * correct grammar * add previously-absent puncuation * remove trailing whitespace Signed-off-by: Mike Ball <mikedball@gmail.com> * run 'make generate' Signed-off-by: Mike Ball <mikedball@gmail.com> * Bump golang.org/x/tools from 0.3.0 to 0.4.0 Bumps [golang.org/x/tools](https://github.com/golang/tools) from 0.3.0 to 0.4.0. - [Release notes](https://github.com/golang/tools/releases) - [Commits](golang/tools@v0.3.0...v0.4.0) --- updated-dependencies: - dependency-name: golang.org/x/tools dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> * Bump github.com/onsi/ginkgo/v2 from 2.5.1 to 2.6.0 Bumps [github.com/onsi/ginkgo/v2](https://github.com/onsi/ginkgo) from 2.5.1 to 2.6.0. - [Release notes](https://github.com/onsi/ginkgo/releases) - [Changelog](https://github.com/onsi/ginkgo/blob/master/CHANGELOG.md) - [Commits](onsi/ginkgo@v2.5.1...v2.6.0) --- updated-dependencies: - dependency-name: github.com/onsi/ginkgo/v2 dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> * Update envtest.md Fix typo * Update SUMMARY.md move the FAQ section to the bottom, after Plugins finish. * 📖 Making section on envtest limitations visible in Master (#3123) * files added Signed-off-by: ShivamTyagi12345 <mergesuccessful@gmail.com> * duplicate removed Signed-off-by: ShivamTyagi12345 <mergesuccessful@gmail.com> Signed-off-by: ShivamTyagi12345 <mergesuccessful@gmail.com> * 🌱 Bump goreleaser/goreleaser-action from 3 to 4 Bumps [goreleaser/goreleaser-action](https://github.com/goreleaser/goreleaser-action) from 3 to 4. - [Release notes](https://github.com/goreleaser/goreleaser-action/releases) - [Commits](goreleaser/goreleaser-action@v3...v4) --- updated-dependencies: - dependency-name: goreleaser/goreleaser-action dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com> * Bump github.com/onsi/ginkgo/v2 from 2.6.0 to 2.6.1 Bumps [github.com/onsi/ginkgo/v2](https://github.com/onsi/ginkgo) from 2.6.0 to 2.6.1. - [Release notes](https://github.com/onsi/ginkgo/releases) - [Changelog](https://github.com/onsi/ginkgo/blob/master/CHANGELOG.md) - [Commits](onsi/ginkgo@v2.6.0...v2.6.1) --- updated-dependencies: - dependency-name: github.com/onsi/ginkgo/v2 dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> * fix: Fix "Available Plugins" link * Bump github.com/onsi/gomega from 1.24.1 to 1.24.2 Bumps [github.com/onsi/gomega](https://github.com/onsi/gomega) from 1.24.1 to 1.24.2. - [Release notes](https://github.com/onsi/gomega/releases) - [Changelog](https://github.com/onsi/gomega/blob/master/CHANGELOG.md) - [Commits](onsi/gomega@v1.24.1...v1.24.2) --- updated-dependencies: - dependency-name: github.com/onsi/gomega dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> * ✨ warning comment on PROJECT file (#3137) * warning comment on PROJECT file * make generate * add link * docs: added missing shell argument to autocompletion snippet The documentation's snippet was missing the shell argument, so the code was not working if added to the .bash_profile. * 🌱 update license date *⚠️ go/v4-alpha: change the layout to follow Golang Standards (#2985) * fix-missing dashes infront of plugins The kubebuilder command was missing the "--" infront of plugins. This meant that it used the go/v3 layout. * :doc: cleanup info and code regards legacy actions using GCP to build KB CLI release * ✨ upgrade k8s from 1.25 to 1.26 (#3147) * Bump github.com/onsi/ginkgo/v2 from 2.6.1 to 2.7.0 Bumps [github.com/onsi/ginkgo/v2](https://github.com/onsi/ginkgo) from 2.6.1 to 2.7.0. - [Release notes](https://github.com/onsi/ginkgo/releases) - [Changelog](https://github.com/onsi/ginkgo/blob/master/CHANGELOG.md) - [Commits](onsi/ginkgo@v2.6.1...v2.7.0) --- updated-dependencies: - dependency-name: github.com/onsi/ginkgo/v2 dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> * Bump golang.org/x/text from 0.5.0 to 0.6.0 Bumps [golang.org/x/text](https://github.com/golang/text) from 0.5.0 to 0.6.0. - [Release notes](https://github.com/golang/text/releases) - [Commits](golang/text@v0.5.0...v0.6.0) --- updated-dependencies: - dependency-name: golang.org/x/text dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> * Bump golang.org/x/tools from 0.4.0 to 0.5.0 Bumps [golang.org/x/tools](https://github.com/golang/tools) from 0.4.0 to 0.5.0. - [Release notes](https://github.com/golang/tools/releases) - [Commits](golang/tools@v0.4.0...v0.5.0) --- updated-dependencies: - dependency-name: golang.org/x/tools dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> * 📖 fix typo in curl command (#3156) fix typo in curl command * Bump github.com/gobuffalo/flect from 0.3.0 to 1.0.0 Bumps [github.com/gobuffalo/flect](https://github.com/gobuffalo/flect) from 0.3.0 to 1.0.0. - [Release notes](https://github.com/gobuffalo/flect/releases) - [Commits](gobuffalo/flect@v0.3.0...v1.0.0) --- updated-dependencies: - dependency-name: github.com/gobuffalo/flect dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com> Signed-off-by: Bryce Palmer <bpalmer@redhat.com> Signed-off-by: dependabot[bot] <support@github.com> Signed-off-by: Jirka Kremser <jiri.kremser@gmail.com> Signed-off-by: jesus m. rodriguez <jesusr@redhat.com> Signed-off-by: Mikhail Sidorov <mixity@yandex.ru> Signed-off-by: Eduardo Coria <emcoria@us.ibm.com> Signed-off-by: Andreas Gerstmayr <agerstmayr@redhat.com> Signed-off-by: Michail Resvanis <mresvani@redhat.com> Signed-off-by: qingwave <isguory@gmail.com> Signed-off-by: Mike Ball <mikedball@gmail.com> Signed-off-by: ShivamTyagi12345 <mergesuccessful@gmail.com> Co-authored-by: Simon Jürgensmeyer <6493966+sj14@users.noreply.github.com> Co-authored-by: Kubernetes Prow Robot <k8s-ci-robot@users.noreply.github.com> Co-authored-by: Camila Macedo <cmacedo@redhat.com> Co-authored-by: Bryce Palmer <bpalmer@redhat.com> Co-authored-by: Tony <kavinjsir@gmail.com> Co-authored-by: Oscar Utbult <oscar.utbult@gmail.com> Co-authored-by: Yash Singh <syash@vmware.com> Co-authored-by: Abhishek koserwal <akoserwa@redhat.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Jirka Kremser <535866+jkremser@users.noreply.github.com> Co-authored-by: laxmikantbpandhare <laxmikantpandhare@gmail.com> Co-authored-by: jesus m. rodriguez <jesusr@redhat.com> Co-authored-by: Phillip Wittrock <Phil.Wittrock@gmail.com> Co-authored-by: Yash Singh <99066083+yashsingh74@users.noreply.github.com> Co-authored-by: Laxmikant Bhaskar Pandhare <47066536+laxmikantbpandhare@users.noreply.github.com> Co-authored-by: astraw99 <wangchengiscool@gmail.com> Co-authored-by: Jonathan Ballet <jon@multani.info> Co-authored-by: Krishna Indani <indanikrishna@gmail.com> Co-authored-by: Nicholas Seemiller <seemiller@gmail.com> Co-authored-by: Mikhail Sidorov <mixity@yandex.ru> Co-authored-by: Marc Villacorta <h0tbird@github.com> Co-authored-by: Shunsuke Ise <ise@ebiiim.com> Co-authored-by: Eduardo M Coria <coriaedu@gmail.com> Co-authored-by: Eduardo Coria <emcoria@us.ibm.com> Co-authored-by: Varsha <varshaprasad96@gmail.com> Co-authored-by: Andreas Gerstmayr <agerstmayr@redhat.com> Co-authored-by: Erik Godding Boye <egboye@gmail.com> Co-authored-by: Michail Resvanis <mresvani@redhat.com> Co-authored-by: Jason Jung <jason1028kr@gmail.com> Co-authored-by: qingwave <isguory@gmail.com> Co-authored-by: Mike Ball <mikedball@gmail.com> Co-authored-by: Jordan Neufeld <neufeldtech@users.noreply.github.com> Co-authored-by: Chinu Anand <66985303+chinu-anand@users.noreply.github.com> Co-authored-by: shivam tyagi <mergesuccessful@gmail.com> Co-authored-by: Yi-Han Chen <hannah51125@gmail.com> Co-authored-by: Gabriele Fedi <gabriele.fedi@enterprisedb.com> Co-authored-by: Gabriele Fedi <91485518+GabriFedi97@users.noreply.github.com> Co-authored-by: Simon Zengerling <simonschulte1991@gmail.com> Co-authored-by: Thomas Güttler <info@thomas-guettler.de>
Sajiyah-Salat
pushed a commit
to Sajiyah-Salat/kubebuilder
that referenced
this pull request
Jun 11, 2023
* add version check for makefile template tools Prevent running controller-gen and kustomize commands with a version that does not match the one specified in the corresponding CONTROLLER_TOOLS_VERSION or KUSTOMIZE_VERSION vars Addresses kubernetes-sigs#3068 * Update makefile target descriptions * Updated descriptions for `kustomize` and `controller-gen` targets. * Reformatted `controller-gen` recipe to reduce line length Signed-off-by: Eduardo Coria <emcoria@us.ibm.com> * update makefile samples Signed-off-by: Eduardo Coria <emcoria@us.ibm.com> Signed-off-by: Eduardo Coria <emcoria@us.ibm.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the change:
Test if the installed versions of
kustomizeandcontroller-genmatch the ones provided in the Makefile corresponding variablesKUSTOMIZE_VERSIONandCONTROLLER_TOOLS_VERSIONto determine whether to re-install or not.Motivation for the change:
Prevent running
controller-genandkustomizecommands with a version that does not match the one specified in the corresponding variables. (details of scenario in #3068)