Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Externalize declarative plugin #3186

Closed
camilamacedo86 opened this issue Jan 26, 2023 · 5 comments · Fixed by #3395
Closed

Externalize declarative plugin #3186

camilamacedo86 opened this issue Jan 26, 2023 · 5 comments · Fixed by #3395
Labels
help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. kind/feature Categorizes issue or PR as related to a new feature. lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release.

Comments

@camilamacedo86
Copy link
Member

What do you want to happen?

Kubebuilder introduces the plugin phase 2 implementation. One way we have a great example of how the community can leverage Kubebuilder to create your plugins would be by achieving the goal of moving the declarative plugin to its repository. See: kubernetes-sigs/kubebuilder-declarative-pattern#293

This task is to track the need to work toward this goal.

Extra Labels

No response

@camilamacedo86 camilamacedo86 added kind/feature Categorizes issue or PR as related to a new feature. help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness. labels Jan 26, 2023
@aimuz
Copy link

aimuz commented Jan 30, 2023

At present, there seem to be many shortcomings in external plug-ins. For example, I want to implement a Layout plug-in. I refer to the implementation of go in the code, and cannot be well ported to external plug-ins. For now, I found that it relies on InjectConfig, but external plug-ins cannot provide

Do you have any good suggestions?

@camilamacedo86 camilamacedo86 added this to the Kubebuilder 4x milestone Feb 11, 2023
@camilamacedo86
Copy link
Member Author

Hi @aimuz,

To address this need @em-r began to work on it. See: kubernetes-sigs/kubebuilder-declarative-pattern#293. The question raised on #3186 (comment) seems specific to the API and its capabilities and would fit better in a new issue. Therefore, I created this i one : #3245 (let's discuss it there)

@em-r
Copy link
Contributor

em-r commented Feb 21, 2023

@camilamacedo86 I think this is a bit similar to our discussion in #3214 (comment)
if it is worth it, I can look into adding support for injecting config into external plugins as part of #3245

@camilamacedo86
Copy link
Member Author

camilamacedo86 commented Feb 21, 2023

Hi @em-r,

if it is worth it, I can look into adding support for injecting config into external plugins as part of #3245

I think we could improve to parse and inject it as well. Yes, please feel free your help is more than welcome !!! 🚀

@camilamacedo86
Copy link
Member Author

We are deprecating the plugin in kubebuilder.
Also, I think we should keep the whole conversation about the new plugin externalized into the declarative project: kubernetes-sigs/kubebuilder-declarative-pattern#293

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. kind/feature Categorizes issue or PR as related to a new feature. lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants