Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CI] doc check ci is blocking bot merges #3268

Closed
camilamacedo86 opened this issue Mar 7, 2023 · 12 comments
Closed

[CI] doc check ci is blocking bot merges #3268

camilamacedo86 opened this issue Mar 7, 2023 · 12 comments
Labels
kind/bug Categorizes issue or PR as related to a bug. lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed.

Comments

@camilamacedo86
Copy link
Member

What broke? What's expected?

We are with an issue related to the job to check if the changes were done only on the docs and skip the other tests, see:

Screenshot 2023-03-07 at 14 37 47

Therefore, we need to fix the issue OR remove this check.

Reproducing this issue

Look at the PRs sometimes it has been failing

KubeBuilder (CLI) Version

master

PROJECT version

No response

Plugin versions

No response

Other versions

No response

Extra Labels

No response

@ashutosh887
Copy link
Contributor

ashutosh887 commented Mar 14, 2023

I would like to inspect the Issue and contribute @camilamacedo86

/assign

@ashutosh887
Copy link
Contributor

ashutosh887 commented Mar 15, 2023

As far can I understand, this needs some modifications in GitHub Actions workflow?
Please guide me @camilamacedo86 @varshaprasad96

@camilamacedo86
Copy link
Member Author

We need to remove the code to skip the tests when only changes on the docs were performed.
Therefore, this issue now is for we are able to re-implement / re-add the checks to skip running the tests when only docs are changed.

@Sajiyah-Salat
Copy link
Contributor

i was working on one doc isssue in kubernetes other repo. And there members found same problem. if its not fixed till now. I will try to fix it in kubebuilder.

@NikhilSharmaWe
Copy link
Member

NikhilSharmaWe commented Apr 25, 2023

PR which added the [CI] doc check: #2608
It was previously working fine, need to identify the changes which were in the GitHub workflow that resulted it not working as expected.

@camilamacedo86
Copy link
Member Author

PR which added the [CI] doc check: #2608
It was previously working fine, need to identify the changes which were in the GitHub workflow that resulted it not working as expected.

We reverted all changes done and it is still broken.
It seems that we need to change because of some deprecations.

@Kavinjsir
Copy link
Contributor

Wondering about the status of this issue? Looks like CI is working well.

@NikhilSharmaWe
Copy link
Member

NikhilSharmaWe commented Aug 28, 2023

It is because the changes made for adding the [CI] doc check #2608 which were causing the blocking are now reverted.

@k8s-triage-robot
Copy link

The Kubernetes project currently lacks enough contributors to adequately respond to all issues.

This bot triages un-triaged issues according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Mark this issue as fresh with /remove-lifecycle stale
  • Close this issue with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jan 27, 2024
@k8s-triage-robot
Copy link

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues.

This bot triages un-triaged issues according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Mark this issue as fresh with /remove-lifecycle rotten
  • Close this issue with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle rotten

@k8s-ci-robot k8s-ci-robot added lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Feb 26, 2024
@k8s-triage-robot
Copy link

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs.

This bot triages issues according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Reopen this issue with /reopen
  • Mark this issue as fresh with /remove-lifecycle rotten
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/close not-planned

@k8s-ci-robot k8s-ci-robot closed this as not planned Won't fix, can't repro, duplicate, stale Mar 27, 2024
@k8s-ci-robot
Copy link
Contributor

@k8s-triage-robot: Closing this issue, marking it as "Not Planned".

In response to this:

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs.

This bot triages issues according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Reopen this issue with /reopen
  • Mark this issue as fresh with /remove-lifecycle rotten
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/close not-planned

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug Categorizes issue or PR as related to a bug. lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed.
Projects
None yet
Development

No branches or pull requests

7 participants