Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

make generate creates the deep-copy.go in two different folders #531

Closed
ghost opened this issue Dec 13, 2018 · 1 comment · Fixed by #542
Closed

make generate creates the deep-copy.go in two different folders #531

ghost opened this issue Dec 13, 2018 · 1 comment · Fixed by #542
Labels
kind/bug Categorizes issue or PR as related to a bug.

Comments

@ghost
Copy link

ghost commented Dec 13, 2018

Version: version.Version{KubeBuilderVersion:"1.0.5", KubernetesVendor:"1.11", GitCommit:"f15ca6865b192f9222882365f525d897564e6bc0", BuildDate:"2018-10-16T21:40:14Z", GoOs:"unknown", GoArch:"unknown"}

Running make generate from the main folder of the project:

  • GOPATH/src/testexample

Two identical zz_generated.deepcopy.go are generated in the following folders:

  • pkg/apis/testexample/pkg/apis/group/v1beta1/
  • pkg/apis/group/v1beta1/

Then the one placed in pkg/apis/testexample/pkg/apis/group/v1beta1/ create misbehaviour
@ghost
Copy link
Author

ghost commented Dec 13, 2018

I believe it is connected to
#359

However the command should warn you or fail and not ending successfully leaving an inconsistent environment behind

@droot droot added the kind/bug Categorizes issue or PR as related to a bug. label Dec 19, 2018
droot added a commit to droot/kubebuilder that referenced this issue Dec 20, 2018
@droot
🐛 report error if GOPATH env is missing
047d8f4 
fixes kubernetes-sigs#531 kubernetes-sigs#359
@droot droot mentioned this issue Dec 20, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
kind/bug Categorizes issue or PR as related to a bug.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

🐛 report error if GOPATH env is missing droot/kubebuilder
1 participant
@droot