Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generate suggested Roles for CR users #886

Closed
erictune opened this issue Jul 24, 2019 · 5 comments · Fixed by #1165 or #1224
Closed

Generate suggested Roles for CR users #886

erictune opened this issue Jul 24, 2019 · 5 comments · Fixed by #1165 or #1224
Assignees
Labels
help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. kind/feature Categorizes issue or PR as related to a new feature.

Comments

@erictune
Copy link

/kind feature

Today, KB use some static roles and it generates a dynamic Role from the //+kubebuilder:rbac:... comments. These cover the permissions the controller needs.

These are not the ones this feature request is talking about.

KB should also generate ClusterRoles to be used by end users who want to CRUD CRs defined by the CRDs in the KB project.

Say my KB project defines something called admirals.
KB should defined a ClusterRole called admiral-editor and admiral-viewer.
These should be something the consumer of the operator is recommended to install.

The consumer of the operator (usually different from the KB user) would be responsible for making any bindings between their users and these Roles.

@erictune erictune added the kind/feature Categorizes issue or PR as related to a new feature. label Jul 24, 2019
@erictune erictune changed the title Generate suggested Roles Generate suggested Roles for CR users Jul 24, 2019
@fejta-bot
Copy link

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Oct 22, 2019
@DirectXMan12
Copy link
Contributor

/remove-lifecycle stale
/help

@k8s-ci-robot k8s-ci-robot removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Nov 6, 2019
@k8s-ci-robot
Copy link
Contributor

@DirectXMan12:
This request has been marked as needing help from a contributor.

Please ensure the request meets the requirements listed here.

If this request no longer meets these requirements, the label can be removed
by commenting with the /remove-help command.

In response to this:

/remove-lifecycle stale
/help

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. label Nov 6, 2019
@camilamacedo86
Copy link
Member

/assign @camilamacedo86

@mengqiy
Copy link
Member

mengqiy commented Nov 20, 2019

Reopen this since we may want to revise it per #1165 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. kind/feature Categorizes issue or PR as related to a new feature.
Projects
None yet
6 participants