Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Comment fixes for code generation #101

Merged
merged 5 commits into from
Apr 30, 2018
Merged

Conversation

pmorie
Copy link
Member

@pmorie pmorie commented Apr 30, 2018

Adds some comments I found helpful while trying to understand the CRD generation flow so that I can add support for kubectl categories.

Interestingly, it looks like there are a bunch of whitespace changes because the tabstop seems inconsistent in the existing code.

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Apr 30, 2018
@pmorie pmorie changed the title Comment fixes Comment fixes for code generation Apr 30, 2018
Copy link
Contributor

@droot droot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR @pmorie

@droot droot merged commit 4987c4d into kubernetes-sigs:master Apr 30, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants