-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cleanup kubebuilder book language #105
Conversation
d70a8ea
to
2fc1cf2
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. A few minor comments.
Feel free to merge it after addressing those.
|
||
See [The Kubebuilder Book](http://book.kubebuilder.io/) for documentation on building APIs with kubebuilder. | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yay!!!
README.md
Outdated
|
||
- [v1beta1.1](https://github.com/kubernetes-sigs/kubebuilder/releases/tag/v1beta1.1) | ||
- [v0.1.7](https://github.com/kubernetes-sigs/kubebuilder/releases/tag/v0.1.7) | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should probably replace this with https://github.com/kubernetes-sigs/kubebuilder/releases/latest
which always point to latest release. Want to avoid updating README for every release.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done
@@ -1,3 +1,7 @@ | |||
{% panel style="info", title="Under Development" %} | |||
This book is being actively developed. | |||
{% endpanel %} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There has to be a better way of sticking a panel on top of very page :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Probably :P
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'll do some research next week. Being able to apply headers to all pages would be useful generally.
export TEST_ASSET_KUBECTL=/usr/local/kubebuilder/bin/kubectl | ||
export TEST_ASSET_KUBE_APISERVER=/usr/local/kubebuilder/bin/kube-apiserver | ||
export TEST_ASSET_ETCD=/usr/local/kubebuilder/bin/etcd | ||
``` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We will have to update this after Fan's PR get merged. I will add the comment to the PR.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1
aae3073
to
00e63e1
Compare
- Add gitbook link - Update release links
00e63e1
to
858cf40
Compare
No description provided.