Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename 'validation' generation to CRD generation #107

Merged
merged 2 commits into from
May 1, 2018
Merged

Rename 'validation' generation to CRD generation #107

merged 2 commits into from
May 1, 2018

Conversation

pmorie
Copy link
Member

@pmorie pmorie commented May 1, 2018

Since this is more about creating CRD definitions than just validations.

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels May 1, 2018
@droot droot requested a review from Liujingfang1 May 1, 2018 16:51
Liujingfang1
Liujingfang1 approved these changes May 1, 2018
View reviewed changes
Copy link
Contributor

@Liujingfang1 Liujingfang1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. The new name makes sense.

@droot droot merged commit 73fb5b2 into kubernetes-sigs:master May 1, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Liujingfang1 Liujingfang1 Liujingfang1 approved these changes

Assignees
No one assigned
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@pmorie @Liujingfang1 @droot @k8s-ci-robot