🏃 more robust golden test #1107
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
cncf-cla: yes
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: mengqiy The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
mengqiy
requested review from
DirectXMan12 and
droot
and removed request for
pwittrock and
Liujingfang1
|
Can we add makefile target or add it to existing makefile targets ? Otherwise looking good to me. |
k8s-ci-robot
added
size/L
mengqiy
force-pushed
the
golden
branch
2 times, most recently
from
d1acf55 to
0ab3b3e
Compare
|
/test pull-kubebuilder-test |
mengqiy
force-pushed
the
golden
branch
4 times, most recently
from
16b92b1 to
e29e07a
Compare
|
Tests are passing. PTAL |
droot
reviewed
Oct 22, 2019
.travis.yml
Outdated
| @@ -27,6 +27,8 @@ before_install: | |||
| # NOTE: The latest version of dep requires go 1.13 | |||
| - if [[ "$TRAVIS_OS_NAME" == "osx" ]]; then mkdir -p /Users/travis/gopath/bin; fi | |||
| - if [[ "$TRAVIS_OS_NAME" == "linux" ]]; then GO111MODULE=on scripts/install_and_setup.sh; fi | |||
| - GO111MODULE=on go get sigs.k8s.io/controller-tools/cmd/controller-gen@v0.2.1 | |||
There was a problem hiding this comment.
we released 0.2.2 yesterday, may be use that. May be we should make these (kustomize below) version as some variables, so that it is easier to change them.
droot
approved these changes
Oct 22, 2019
droot
added
the
lgtm
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added a more robust golden test:
fixes #1003