Make order of generated yaml from kubebuilder create config --crds deterministic #123
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
the
cncf-cla: yes
k8s-ci-robot
added
the
size/L
droot
previously approved these changes
May 3, 2018
droot
reviewed
May 3, 2018
| kind: "" | ||
| plural: "" | ||
| conditions: null | ||
| EOF |
There was a problem hiding this comment.
I took another look and realized that deterministic ordering can be unit tested in Go itself. This feels like an anti-pattern to have that functionality tested here test.sh ?
There was a problem hiding this comment.
If it is possible to test in go, that is the direction I'd prefer. While necessary for the moment, this approach was a disaster in kubectl.
There was a problem hiding this comment.
Yeah - i’ll move the test to go
|
@pmorie I am also fine with making that a TODO and not blocking this on that. |
|
Since the point of this PR is to increase test coverage, I am going to merge it. We can move logic from the test.sh to e2e tests in go independent of this PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
... to facilitate adding test cases for validations etc in different CRDs.