Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hotfix for TRAVIS error introduced by #1016 #1288

Closed
wants to merge 1 commit into from

Conversation

Adirio
Copy link
Contributor

@Adirio Adirio commented Jan 8, 2020

Fixes the Travis error introduced by #1016

The result of {{ printf "%q" .BoilerplatePath }} is "hack/boilerplate.txt" while Travis is expecting ./hack/boilerplate.txt. Either the testdata should be change to reflect #1016 or ./{{ .Boilerplate }} can be used instead. Both work as expected.

@k8s-ci-robot k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Jan 8, 2020
@k8s-ci-robot
Copy link
Contributor

Hi @Adirio. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jan 8, 2020
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: Adirio
To complete the pull request process, please assign droot
You can assign the PR to them by writing /assign @droot in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@Adirio Adirio force-pushed the hotfix-1016 branch 2 times, most recently from b7c6ee9 to 1b4c224 Compare January 8, 2020 11:33
Signed-off-by: Adrian Orive <adrian.orive.oneca@gmail.com>
@camilamacedo86
Copy link
Member

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jan 8, 2020
Copy link
Member

@camilamacedo86 camilamacedo86 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is the fix. (just rebase with master and run make generate)
It was done already in other PR's as well and worked fine.

See here that the error is in the golden_test.

Screenshot 2020-01-08 at 12 25 48

/lgtm /approved.

@Adirio
Copy link
Contributor Author

Adirio commented Jan 8, 2020

It is the fix. (just rebase with master and run make generate)
It was done already in other PR's as well and worked fine.

I was testing two different options (that is why I marked it as WIP).

/lgtm /approved.

@camilamacedo86 I think that labels need to be in separate lines. And also, I think that you can't /approve as a reviewer. I would apreciate if you label this as /lgtm in a separate line.

@Adirio Adirio changed the title [WIP] Hotfix for TRAVIS error introduced by #1016 Hotfix for TRAVIS error introduced by #1016 Jan 8, 2020
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jan 8, 2020
@camilamacedo86
Copy link
Member

/lgtm
/approved

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 8, 2020
@camilamacedo86
Copy link
Member

camilamacedo86 commented Jan 8, 2020

HI @Adirio,

My comments are to register that it is ok /lgtm /approved in my review. However, in order to the bot add the label approve in the PR for it be merged is required to be approver in the org/repo which I am not. (I can just set /lgtm)

@Adirio
Copy link
Contributor Author

Adirio commented Jan 9, 2020

@DirectXMan12 or @mengqiy can we add this? It is a hotfix to solve a Travis issue that is affecting several PRs as shown by all the references to this PR.

So merging this ASAP would prevent further confussion like in #1287.

/kind bug

@gerred
Copy link

gerred commented Jan 10, 2020

/lgtm

@Adirio
Copy link
Contributor Author

Adirio commented Jan 10, 2020

#1287 has been merged before this PR with the fix included in it.

@Adirio Adirio closed this Jan 10, 2020
@Adirio Adirio deleted the hotfix-1016 branch January 10, 2020 10:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants