-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Hotfix for TRAVIS error introduced by #1016 #1288
Conversation
Hi @Adirio. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: Adirio The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
b7c6ee9
to
1b4c224
Compare
Signed-off-by: Adrian Orive <adrian.orive.oneca@gmail.com>
/ok-to-test |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I was testing two different options (that is why I marked it as WIP).
@camilamacedo86 I think that labels need to be in separate lines. And also, I think that you can't |
/lgtm |
HI @Adirio, My comments are to register that it is ok /lgtm /approved in my review. However, in order to the bot add the label approve in the PR for it be merged is required to be approver in the org/repo which I am not. (I can just set /lgtm) |
@DirectXMan12 or @mengqiy can we add this? It is a hotfix to solve a Travis issue that is affecting several PRs as shown by all the references to this PR. So merging this ASAP would prevent further confussion like in #1287. /kind bug |
/lgtm |
#1287 has been merged before this PR with the fix included in it. |
Fixes the Travis error introduced by #1016
The result of
{{ printf "%q" .BoilerplatePath }}
is"hack/boilerplate.txt"
while Travis is expecting./hack/boilerplate.txt
. Either thetestdata
should be change to reflect #1016 or./{{ .Boilerplate }}
can be used instead. Both work as expected.