-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Group templates under a internal subpackage #1348
Group templates under a internal subpackage #1348
Conversation
Hi @Adirio. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
0234351
to
fafbdb3
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/approve
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Adirio, mengqiy The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Signed-off-by: Adrian Orive <adrian.orive.oneca@gmail.com>
Signed-off-by: Adrian Orive <adrian.orive.oneca@gmail.com>
fafbdb3
to
63fc6f8
Compare
/lgtm |
Description
Template files are found in three
pkg/scaffold/
subpackages:project
v1
v2
v2/internal
belongs scaffolding machinery.The following grouping and movement have been done:
v2/internal
has been moved tointernal/machinery
v1
has been moved tointernal/templates/v1
v2
has been moved tointernal/templates/v2
project
contained files belonging tov1
and files being used by both versions. They have been moved tointernal/templates/v1
and the ones that are also being used byv2
have been duplicated ininternal/templates/v2
.Motivation
This PR is scoped under #1218
Closes #1264