Make docs gen ordering deterministic #135
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
size/M
pwittrock
force-pushed
the
docs-gen
branch
3 times, most recently
from
a4b97cd
to
066e1bd
Compare
k8s-ci-robot
added
size/XL
|
@droot I know the testing is headed a terrible direction, but I think it gives us the cheap coverage we need to make sure the docs and config generation are tested. Lets look into building an e2e framework that will scale in the next 4 Sprints. |
- Generate docs - Compare results to expected - Delete unused test directories
pwittrock
changed the title
|
@pwittrock coverage for docs is important so this is good for short term. Merging it. |
droot
approved these changes
May 9, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make the table of contents deterministic when generating API docs.
Also add tests for docs generation.