Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Trim spaces from beginning and end of templates #141

Closed
wants to merge 4 commits into from

Conversation

kragniz
Copy link
Contributor

@kragniz kragniz commented May 10, 2018

This prevents some slightly strange looking packages being generated
with init.

This prevents some slightly strange looking packages being generated
with init.
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels May 10, 2018
@droot
Copy link
Contributor

droot commented May 11, 2018

@kragniz Thanks for submitting this change.
I was wondering if we can run the generated *.go files through a go-formatter to take care of all the formatting issues. Would you like to give it a shot ?

@kragniz
Copy link
Contributor Author

kragniz commented May 11, 2018

A bit more complex, but probably a better solution. I'll see how easy it is to use gofmt before writing out files.

@kragniz
Copy link
Contributor Author

kragniz commented May 11, 2018

I've continued this in #147

@kragniz kragniz closed this May 11, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants