test scripts: add missing addons test, some refactoring #1449
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
estroz
commented
Mar 28, 2020
estroz
commented
- generate_testdata.sh: refactor common code for v2 projects
- test.sh: add missing addons test
k8s-ci-robot
added
the
cncf-cla: yes
k8s-ci-robot
added
the
size/M
camilamacedo86
requested changes
Mar 30, 2020
There was a problem hiding this comment.
@estroz where is the Travis CI execution which will verify the changes made in this PR?
Could you please check that?
|
/hold since the Trevis test was not executed here. |
k8s-ci-robot
added
the
do-not-merge/hold
|
/hold cancel |
k8s-ci-robot
removed
the
do-not-merge/hold
camilamacedo86
approved these changes
Mar 30, 2020
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: camilamacedo86, estroz The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
lgtm
|
You may need to close and re-open this one. |
|
/test continuous-integration/travis-ci/pr |
|
/retest |
test.sh: add missing addons test
estroz
force-pushed
the
refactor/update-scripts
branch
from
2f239ee to
768236e
Compare
k8s-ci-robot
removed
the
lgtm
|
/lgtm |
k8s-ci-robot
added
the
lgtm
|
/retest |
|
/test all |
|
/test trevis-ci |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.