Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move quick start guide from README.md into the GitBook. #146

Merged
merged 1 commit into from
May 14, 2018

Conversation

pwittrock
Copy link
Contributor

No description provided.

@k8s-ci-robot k8s-ci-robot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels May 11, 2018
Copy link
Contributor

@droot droot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, one minor comment.

README.md Outdated
@@ -10,11 +10,9 @@ the release program.* To build your own release see [CONTRIBUTING.md](CONTRIBUT

[Release](https://github.com/kubernetes-sigs/kubebuilder/releases):

- [latest](https://github.com/kubernetes-sigs/kubebuilder/releases/latest)

## Book
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would suggest adding Getting Started heading just before the book heading because "book" heading might be perceived as some long form of reading which might discourage some impatient users :)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

@@ -0,0 +1,24 @@
## GoDoc

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I feel the content in this file is more like notes to users. Maybe we can create a more organized structure.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changed this just to be links to the GoDoc

- [config libraries](https://godoc.org/github.com/kubernetes-sigs/kubebuilder/pkg/config)
- [signals libraries](https://godoc.org/github.com/kubernetes-sigs/kubebuilder/pkg/signals)

Kubebuilder generates codes for custom resource fields, and controller components such as watchers and informers. You have to add code generation tags in form of comment directives to initiate the code generation:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These code generation tags are so important. I missed one of the informer tag in the core type controller template. It caused a failure and I spent a few hours debugging it. I'd like to see we put the docs for the tags in a more obvious place. Something like Important note in the controller documentation.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is a section on this in the Controller section. Added a warning note as well.

@pwittrock pwittrock force-pushed the docs-gen branch 4 times, most recently from 62a532e to 08bbd1a Compare May 14, 2018 20:04
@pwittrock pwittrock merged commit 2f9c87f into kubernetes-sigs:master May 14, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants