-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
plugins: move --plugins
from global to init
-only
#1465
plugins: move --plugins
from global to init
-only
#1465
Conversation
/hold while we discuss |
739dfd7
to
32a970e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am ok with these changes. 👍
1 nit only: I think is better use len(string) > 0 than !=""
32a970e
to
8c4375c
Compare
} | ||
c.cliPluginKeys[pluginName] = pluginVersion | ||
} | ||
c.cliPluginKey = strings.TrimSpace(c.cliPluginKey) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It is :
/lgtm
for me.
Hi @estroz missing run |
to be used for scaffolding at a time, and a config's 'layout' value should be used for other commands. Also change the implementation of resolvePluginsByKey to only match one key, and add tests
8c4375c
to
8707feb
Compare
/approve |
/lgtm |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: camilamacedo86, estroz, mengqiy The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/hold cancel |
24cddcc
into
kubernetes-sigs:feature/plugins-part-2-electric-boogaloo
Per discussion in #1403 (comment):
There still may be a use case for phase 1 global--plugins
: I scaffold a project with--plugins=go-x
then want to create an API using plugingo-y
, which "understands" a project initialized bygo-y
; without a global--plugins
flag I would have to change my config'slayout
value.Thoughts?/cc @DirectXMan12 @mengqiy @joelanford